Skip to content

Commit 86e939e

Browse files
committed
Change the output artifact path to $root_dir/obj/$image when running locally
1 parent d92f01a commit 86e939e

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

src/ci/docker/README.md

+4-7
Original file line numberDiff line numberDiff line change
@@ -14,20 +14,17 @@ for example:
1414
./src/ci/docker/run.sh x86_64-gnu
1515
```
1616

17-
Images will output artifacts in an `obj` dir at the root of a repository. Note
17+
Images will output artifacts in an `obj/$image_name` dir at the root of a repository. Note
1818
that the script will overwrite the contents of this directory.
1919

2020
To match conditions in rusts CI, also set the environment variable `DEPLOY=1`, e.g.:
2121
```
2222
DEPLOY=1 ./src/ci/docker/run.sh x86_64-gnu
2323
```
2424

25-
**NOTE**: Re-using the same `obj` dir with different docker images with
26-
the same target triple (e.g. `dist-x86_64-linux` and `dist-various-1`)
27-
may result in strange linker errors, due shared library versions differing between platforms.
28-
29-
If you encounter any issues when using multiple Docker images, try deleting your `obj` directory
30-
before running your command.
25+
**NOTE**: In CI, the script outputs the artifacts to the `obj` directory,
26+
while locally, to the `obj/$image_name` directory. This is primarily to prevent
27+
strange linker errors when using multiple Docker images.
3128

3229
## Filesystem layout
3330

src/ci/docker/run.sh

+7-3
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,20 @@ ci_dir="`dirname $script_dir`"
3333
src_dir="`dirname $ci_dir`"
3434
root_dir="`dirname $src_dir`"
3535

36-
objdir=$root_dir/obj
36+
source "$ci_dir/shared.sh"
37+
38+
if isCI; then
39+
objdir=$root_dir/obj
40+
else
41+
objdir=$root_dir/obj/$image
42+
fi
3743
dist=$objdir/build/dist
3844

3945

4046
if [ -d "$root_dir/.git" ]; then
4147
IS_GIT_SOURCE=1
4248
fi
4349

44-
source "$ci_dir/shared.sh"
45-
4650
CACHE_DOMAIN="${CACHE_DOMAIN:-ci-caches.rust-lang.org}"
4751

4852
if [ -f "$docker_dir/$image/Dockerfile" ]; then

0 commit comments

Comments
 (0)