Skip to content

Commit 837be0d

Browse files
committed
bootstrap: exclude link_jobs from check_ci_llvm! checks
This option is largely there to help people to manage the memory usage on their systems during the LLVM build. The linking phase is as usual are the heaviest part of the build and if in an unlucky conincidence the circumstances align to kick off N_CORES links at the same time, not even hundreds of GiB of memory may suffice. It makes a lot of sense for developers to set&forget this option unconditionally. Not to mention, this option does not, in any way, affect the generated code (at least as far as I know.) It really doesn’t matter what option the CI build LLVM used here and/or if it matches with the user’s configuration. Finally, 0 actual link jobs implied by `download-ci-llvm` is guaranteed to stay within the limits that are reasonable to set with this option.
1 parent e927184 commit 837be0d

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

Diff for: src/bootstrap/src/core/config/config.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1776,7 +1776,6 @@ impl Config {
17761776
check_ci_llvm!(static_libstdcpp);
17771777
check_ci_llvm!(targets);
17781778
check_ci_llvm!(experimental_targets);
1779-
check_ci_llvm!(link_jobs);
17801779
check_ci_llvm!(clang_cl);
17811780
check_ci_llvm!(version_suffix);
17821781
check_ci_llvm!(cflags);

0 commit comments

Comments
 (0)