Skip to content

Commit 7f75815

Browse files
committed
Auto merge of rust-lang#16252 - Urhengulas:dont-assert-debug, r=Veykril
internal: Switch to `expected.assert_eq` for `ide` tests This PR switches from `assert_debug_eq` to `assert_eq` and only compares parts of the result and not the whole. The aim is to only compare parts which are relevant to the test and also make it more readable. Part of rust-lang#14268. ## Questions - [x] Can I use `Vec`? If not, what is the alternative? I assume I cannot because of: https://github.com/rust-lang/rust-analyzer/blob/c3a00b5468576de4e39adc8fa5ceae35a0024e49/docs/dev/architecture.md?plain=1#L413 - [x] Should I group it by file, as proposed by Lukas? ``` file_id 1: source_file_edits: - Indel { insert: "foo2", delete: 4..7 } file_id 2: file_system_edits: MoveFile AnchoredPathBuf { anchor: FileId(2), path: "foo2.rs", } ``` - [x] Is it okay to ignore `CreateFile` events? They do not have a FileId, which would be problematic, but they do not occur in the existing tests, so I marked them as `unreachable!()` so far.
2 parents c3a00b5 + 656ac10 commit 7f75815

File tree

1 file changed

+240
-273
lines changed

1 file changed

+240
-273
lines changed

0 commit comments

Comments
 (0)