|
1 | | -use std::iter; |
| 1 | +use std::{iter, usize}; |
2 | 2 |
|
| 3 | +use rustc_const_eval::const_eval::mk_eval_cx_for_const_val; |
| 4 | +use rustc_index::bit_set::BitSet; |
3 | 5 | use rustc_index::IndexSlice; |
4 | 6 | use rustc_middle::mir::patch::MirPatch; |
5 | 7 | use rustc_middle::mir::*; |
| 8 | +use rustc_middle::ty; |
6 | 9 | use rustc_middle::ty::layout::{IntegerExt, TyAndLayout}; |
| 10 | +use rustc_middle::ty::util::Discr; |
7 | 11 | use rustc_middle::ty::{ParamEnv, ScalarInt, Ty, TyCtxt}; |
| 12 | +use rustc_mir_dataflow::impls::{borrowed_locals, MaybeTransitiveLiveLocals}; |
| 13 | +use rustc_mir_dataflow::Analysis; |
8 | 14 | use rustc_target::abi::Integer; |
9 | 15 | use rustc_type_ir::TyKind::*; |
10 | 16 |
|
@@ -48,6 +54,10 @@ impl<'tcx> MirPass<'tcx> for MatchBranchSimplification { |
48 | 54 | should_cleanup = true; |
49 | 55 | continue; |
50 | 56 | } |
| 57 | + if simplify_to_copy(tcx, body, bb_idx, param_env).is_some() { |
| 58 | + should_cleanup = true; |
| 59 | + continue; |
| 60 | + } |
51 | 61 | } |
52 | 62 |
|
53 | 63 | if should_cleanup { |
@@ -515,3 +525,210 @@ impl<'tcx> SimplifyMatch<'tcx> for SimplifyToExp { |
515 | 525 | } |
516 | 526 | } |
517 | 527 | } |
| 528 | + |
| 529 | +/// This is primarily used to merge these copy statements that simplified the canonical enum clone method by GVN. |
| 530 | +/// The GVN simplified |
| 531 | +/// ```ignore (syntax-highlighting-only) |
| 532 | +/// match a { |
| 533 | +/// Foo::A(x) => Foo::A(*x), |
| 534 | +/// Foo::B => Foo::B |
| 535 | +/// } |
| 536 | +/// ``` |
| 537 | +/// to |
| 538 | +/// ```ignore (syntax-highlighting-only) |
| 539 | +/// match a { |
| 540 | +/// Foo::A(_x) => a, // copy a |
| 541 | +/// Foo::B => Foo::B |
| 542 | +/// } |
| 543 | +/// ``` |
| 544 | +/// This function will simplify into a copy statement. |
| 545 | +fn simplify_to_copy<'tcx>( |
| 546 | + tcx: TyCtxt<'tcx>, |
| 547 | + body: &mut Body<'tcx>, |
| 548 | + switch_bb_idx: BasicBlock, |
| 549 | + param_env: ParamEnv<'tcx>, |
| 550 | +) -> Option<()> { |
| 551 | + if switch_bb_idx != START_BLOCK { |
| 552 | + return None; |
| 553 | + } |
| 554 | + let bbs = &body.basic_blocks; |
| 555 | + // Check if the copy source matches the following pattern. |
| 556 | + // _2 = discriminant(*_1); // "*_1" is the expected the copy source. |
| 557 | + // switchInt(move _2) -> [0: bb3, 1: bb2, otherwise: bb1]; |
| 558 | + let &Statement { |
| 559 | + kind: StatementKind::Assign(box (discr_place, Rvalue::Discriminant(expected_src_place))), |
| 560 | + .. |
| 561 | + } = bbs[switch_bb_idx].statements.last()? |
| 562 | + else { |
| 563 | + return None; |
| 564 | + }; |
| 565 | + let expected_src_ty = expected_src_place.ty(body.local_decls(), tcx); |
| 566 | + if !expected_src_ty.ty.is_enum() || expected_src_ty.variant_index.is_some() { |
| 567 | + return None; |
| 568 | + } |
| 569 | + let expected_dest_place = Place::return_place(); |
| 570 | + let expected_dest_ty = expected_dest_place.ty(body.local_decls(), tcx); |
| 571 | + if expected_dest_ty.ty != expected_src_ty.ty || expected_dest_ty.variant_index.is_some() { |
| 572 | + return None; |
| 573 | + } |
| 574 | + let targets = match bbs[switch_bb_idx].terminator().kind { |
| 575 | + TerminatorKind::SwitchInt { ref discr, ref targets, .. } |
| 576 | + if discr.place() == Some(discr_place) => |
| 577 | + { |
| 578 | + targets |
| 579 | + } |
| 580 | + _ => return None, |
| 581 | + }; |
| 582 | + // We require that the possible target blocks all be distinct. |
| 583 | + if !targets.is_distinct() { |
| 584 | + return None; |
| 585 | + } |
| 586 | + if !bbs[targets.otherwise()].is_empty_unreachable() { |
| 587 | + return None; |
| 588 | + } |
| 589 | + // Check that destinations are identical, and if not, then don't optimize this block. |
| 590 | + let mut target_iter = targets.iter(); |
| 591 | + let first_terminator_kind = &bbs[target_iter.next().unwrap().1].terminator().kind; |
| 592 | + if !target_iter |
| 593 | + .all(|(_, other_target)| first_terminator_kind == &bbs[other_target].terminator().kind) |
| 594 | + { |
| 595 | + return None; |
| 596 | + } |
| 597 | + |
| 598 | + let borrowed_locals = borrowed_locals(body); |
| 599 | + let mut live = None; |
| 600 | + |
| 601 | + for (index, target_bb) in targets.iter() { |
| 602 | + let stmts = &bbs[target_bb].statements; |
| 603 | + if stmts.is_empty() { |
| 604 | + return None; |
| 605 | + } |
| 606 | + if let [Statement { kind: StatementKind::Assign(box (place, rvalue)), .. }] = |
| 607 | + bbs[target_bb].statements.as_slice() |
| 608 | + { |
| 609 | + let dest_ty = place.ty(body.local_decls(), tcx); |
| 610 | + if dest_ty.ty != expected_src_ty.ty || dest_ty.variant_index.is_some() { |
| 611 | + return None; |
| 612 | + } |
| 613 | + let ty::Adt(def, _) = dest_ty.ty.kind() else { |
| 614 | + return None; |
| 615 | + }; |
| 616 | + if expected_dest_place != *place { |
| 617 | + return None; |
| 618 | + } |
| 619 | + match rvalue { |
| 620 | + // Check if `_3 = const Foo::B` can be transformed to `_3 = copy *_1`. |
| 621 | + Rvalue::Use(Operand::Constant(box constant)) |
| 622 | + if let Const::Val(const_, ty) = constant.const_ => |
| 623 | + { |
| 624 | + let (ecx, op) = |
| 625 | + mk_eval_cx_for_const_val(tcx.at(constant.span), param_env, const_, ty)?; |
| 626 | + let variant = ecx.read_discriminant(&op).ok()?; |
| 627 | + if !def.variants()[variant].fields.is_empty() { |
| 628 | + return None; |
| 629 | + } |
| 630 | + let Discr { val, .. } = ty.discriminant_for_variant(tcx, variant)?; |
| 631 | + if val != index { |
| 632 | + return None; |
| 633 | + } |
| 634 | + } |
| 635 | + Rvalue::Use(Operand::Copy(src_place)) if *src_place == expected_src_place => {} |
| 636 | + // Check if `_3 = Foo::B` can be transformed to `_3 = copy *_1`. |
| 637 | + Rvalue::Aggregate(box AggregateKind::Adt(_, variant_index, _, _, None), fields) |
| 638 | + if fields.is_empty() |
| 639 | + && let Some(Discr { val, .. }) = |
| 640 | + expected_src_ty.ty.discriminant_for_variant(tcx, *variant_index) |
| 641 | + && val == index => {} |
| 642 | + _ => return None, |
| 643 | + } |
| 644 | + } else { |
| 645 | + // If the BB contains more than one statement, we have to check if these statements can be ignored. |
| 646 | + let mut lived_stmts: BitSet<usize> = |
| 647 | + BitSet::new_filled(bbs[target_bb].statements.len()); |
| 648 | + let mut expected_copy_stmt = None; |
| 649 | + for (statement_index, statement) in bbs[target_bb].statements.iter().enumerate().rev() { |
| 650 | + let loc = Location { block: target_bb, statement_index }; |
| 651 | + if let StatementKind::Assign(assign) = &statement.kind { |
| 652 | + if !assign.1.is_safe_to_remove() { |
| 653 | + return None; |
| 654 | + } |
| 655 | + } |
| 656 | + match &statement.kind { |
| 657 | + StatementKind::Assign(box (place, _)) |
| 658 | + | StatementKind::SetDiscriminant { place: box place, .. } |
| 659 | + | StatementKind::Deinit(box place) => { |
| 660 | + if place.is_indirect() || borrowed_locals.contains(place.local) { |
| 661 | + return None; |
| 662 | + } |
| 663 | + let live = live.get_or_insert_with(|| { |
| 664 | + MaybeTransitiveLiveLocals::new(&borrowed_locals) |
| 665 | + .into_engine(tcx, body) |
| 666 | + .iterate_to_fixpoint() |
| 667 | + .into_results_cursor(body) |
| 668 | + }); |
| 669 | + live.seek_before_primary_effect(loc); |
| 670 | + if !live.get().contains(place.local) { |
| 671 | + lived_stmts.remove(statement_index); |
| 672 | + } else if let StatementKind::Assign(box ( |
| 673 | + _, |
| 674 | + Rvalue::Use(Operand::Copy(src_place)), |
| 675 | + )) = statement.kind |
| 676 | + && expected_copy_stmt.is_none() |
| 677 | + && expected_src_place == src_place |
| 678 | + && expected_dest_place == *place |
| 679 | + { |
| 680 | + // There is only one statement that cannot be ignored that can be used as an expected copy statement. |
| 681 | + expected_copy_stmt = Some(statement_index); |
| 682 | + } else { |
| 683 | + return None; |
| 684 | + } |
| 685 | + } |
| 686 | + StatementKind::StorageLive(_) |
| 687 | + | StatementKind::StorageDead(_) |
| 688 | + | StatementKind::Nop => (), |
| 689 | + |
| 690 | + StatementKind::Retag(_, _) |
| 691 | + | StatementKind::Coverage(_) |
| 692 | + | StatementKind::Intrinsic(_) |
| 693 | + | StatementKind::ConstEvalCounter |
| 694 | + | StatementKind::PlaceMention(_) |
| 695 | + | StatementKind::FakeRead(_) |
| 696 | + | StatementKind::AscribeUserType(_, _) => { |
| 697 | + return None; |
| 698 | + } |
| 699 | + } |
| 700 | + } |
| 701 | + let expected_copy_stmt = expected_copy_stmt?; |
| 702 | + // We can ignore the paired StorageLive and StorageDead. |
| 703 | + let mut storage_live_locals: BitSet<Local> = BitSet::new_empty(body.local_decls.len()); |
| 704 | + for stmt_index in lived_stmts.iter() { |
| 705 | + let statement = &bbs[target_bb].statements[stmt_index]; |
| 706 | + match &statement.kind { |
| 707 | + StatementKind::Assign(_) if expected_copy_stmt == stmt_index => {} |
| 708 | + StatementKind::StorageLive(local) |
| 709 | + if *local != expected_dest_place.local |
| 710 | + && storage_live_locals.insert(*local) => {} |
| 711 | + StatementKind::StorageDead(local) |
| 712 | + if *local != expected_dest_place.local |
| 713 | + && storage_live_locals.remove(*local) => {} |
| 714 | + StatementKind::Nop => {} |
| 715 | + _ => return None, |
| 716 | + } |
| 717 | + } |
| 718 | + if !storage_live_locals.is_empty() { |
| 719 | + return None; |
| 720 | + } |
| 721 | + } |
| 722 | + } |
| 723 | + let statement_index = bbs[switch_bb_idx].statements.len(); |
| 724 | + let parent_end = Location { block: switch_bb_idx, statement_index }; |
| 725 | + let mut patch = MirPatch::new(body); |
| 726 | + patch.add_assign( |
| 727 | + parent_end, |
| 728 | + expected_dest_place, |
| 729 | + Rvalue::Use(Operand::Copy(expected_src_place)), |
| 730 | + ); |
| 731 | + patch.patch_terminator(switch_bb_idx, first_terminator_kind.clone()); |
| 732 | + patch.apply(body); |
| 733 | + Some(()) |
| 734 | +} |
0 commit comments