Rollup merge of rust-lang#130306 - onur-ozkan:avoid-submodule-updates-in-tests, r=Kobzol

Zalathar · web-flow · commit 59698a711f8f · 2024-09-14T11:53:13.000+10:00
avoid updating LLVM submodule during bootstrap unit tests

To test this, make sure you don't have `src/llvm-project` fetched and then set `llvm.download-ci-llvm=true` and run `x test bootstrap`.
diff --git a/src/bootstrap/src/core/config/config.rs b/src/bootstrap/src/core/config/config.rs
@@ -2739,6 +2739,8 @@ impl Config {
                 return false;
             }
 
+            // Fetching the LLVM submodule is unnecessary for self-tests.
+            #[cfg(not(feature = "bootstrap-self-test"))]
             self.update_submodule("src/llvm-project");
 
             // Check for untracked changes in `src/llvm-project`.

Original file line number	Diff line number	Diff line change
`@@ -2739,6 +2739,8 @@ impl Config {`
`2739`	`2739`	`return false;`
`2740`	`2740`	`}`
`2741`	`2741`
	`2742`	`+ // Fetching the LLVM submodule is unnecessary for self-tests.`
	`2743`	`+ #[cfg(not(feature = "bootstrap-self-test"))]`
`2742`	`2744`	`self.update_submodule("src/llvm-project");`
`2743`	`2745`
`2744`	`2746`	// Check for untracked changes in `src/llvm-project`.