Ensure strings created with const_str get the unnamed_addr attribute

thomcc · thomcc · commit 268f5c57b9da · 2023-11-15T07:56:40.000Z
diff --git a/compiler/rustc_codegen_llvm/src/common.rs b/compiler/rustc_codegen_llvm/src/common.rs
@@ -203,6 +203,7 @@ impl<'ll, 'tcx> ConstMethods<'tcx> for CodegenCx<'ll, 'tcx> {
                 unsafe {
                     llvm::LLVMSetInitializer(g, sc);
                     llvm::LLVMSetGlobalConstant(g, True);
+                    llvm::LLVMSetUnnamedAddress(g, llvm::UnnamedAddr::Global);
                     llvm::LLVMRustSetLinkage(g, llvm::Linkage::InternalLinkage);
                 }
                 (s.to_owned(), g)

Original file line number	Diff line number	Diff line change
`@@ -203,6 +203,7 @@ impl<'ll, 'tcx> ConstMethods<'tcx> for CodegenCx<'ll, 'tcx> {`
`203`	`203`	`unsafe {`
`204`	`204`	`llvm::LLVMSetInitializer(g, sc);`
`205`	`205`	`llvm::LLVMSetGlobalConstant(g, True);`
	`206`	`+ llvm::LLVMSetUnnamedAddress(g, llvm::UnnamedAddr::Global);`
`206`	`207`	`llvm::LLVMRustSetLinkage(g, llvm::Linkage::InternalLinkage);`
`207`	`208`	`}`
`208`	`209`	`(s.to_owned(), g)`