Skip to content
This repository was archived by the owner on May 28, 2025. It is now read-only.

Commit 07bc73b

Browse files
committed
Fix review comments
1 parent 006edb5 commit 07bc73b

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/ci/run.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@ if [ "$DIST_SRC" = "" ]; then
8484
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --disable-dist-src"
8585
fi
8686

87+
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.codegen-backends=llvm,cranelift"
88+
8789
# Always set the release channel for bootstrap; this is normally not important (i.e., only dist
8890
# builds would seem to matter) but in practice bootstrap wants to know whether we're targeting
8991
# master, beta, or stable with a build to determine whether to run some checks (notably toolstate).
@@ -105,7 +107,6 @@ if [ "$DEPLOY$DEPLOY_ALT" = "1" ]; then
105107
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.verify-llvm-ir"
106108
fi
107109

108-
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.codegen-backends=llvm,cranelift"
109110
else
110111
# We almost always want debug assertions enabled, but sometimes this takes too
111112
# long for too little benefit, so we just turn them off.
@@ -126,8 +127,6 @@ else
126127

127128
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.verify-llvm-ir"
128129

129-
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.codegen-backends=llvm,cranelift"
130-
131130
# We enable this for non-dist builders, since those aren't trying to produce
132131
# fresh binaries. We currently don't entirely support distributing a fresh
133132
# copy of the compiler (including llvm tools, etc.) if we haven't actually

src/tools/build-manifest/src/versions.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ impl PkgType {
108108
ReproducibleArtifacts => HOSTS,
109109
RustcDocs => HOSTS,
110110
Cargo => HOSTS,
111-
// FIXME should this use the exact list of targets for which we build cg_clif?
112111
RustcCodegenCranelift => HOSTS,
113112
RustMingw => MINGW,
114113
RustStd => TARGETS,

0 commit comments

Comments
 (0)