Skip to content

Commit d91e843

Browse files
bors[bot]adamgreig
andauthored
Merge #246
246: Always link pre-built asm, required for new cache management functions r=therealprof a=adamgreig In #234 we added new `__enable_icache` and `__enable_dcache` assembly routines, but without providing an inline assembly version, to reduce duplication and since there wasn't an expected performance impact. However, our build.rs currently only links the pre-built object if the `inline-asm` feature is disabled, which means currently you can't call `enable_icache()` and use `inline-asm` at the same time. This PR makes us always link against the pre-built objects (for thumb targets) even if `inline-asm` is used; the pre-built object would only be used for the cache management routines at present but we may want to put more routines into the assembly blob only in the future. Closes #245. Co-authored-by: Adam Greig <[email protected]>
2 parents ec2e178 + 9c3bbc2 commit d91e843

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

build.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ fn main() {
66
let out_dir = PathBuf::from(env::var("OUT_DIR").unwrap());
77
let name = env::var("CARGO_PKG_NAME").unwrap();
88

9-
if target.starts_with("thumb") && env::var_os("CARGO_FEATURE_INLINE_ASM").is_none() {
9+
if target.starts_with("thumb") {
1010
fs::copy(
1111
format!("bin/{}.a", target),
1212
out_dir.join(format!("lib{}.a", name)),

0 commit comments

Comments
 (0)