Merge #270

270: Add GitHub actions for CI r=adamgreig a=therealprof

This changes CI from Travis CI to GHA which should not only vastly simplify the maintenance (by getting rid of pulling custom binaries from japaric's repository) but also speeds up the CI process and adds rustfmt as well as clippy checks for good measure.

There's still room for optimisation but this has taken me long enough and plenty of sweat to get to this stage so my recommendation would be to merge it.

Co-authored-by: Daniel Egger <[email protected]>

Author: bors[bot]

cortex-m-rt/.github/bors.toml

@@ -1,4 +1,18 @@
 block_labels = ["needs-decision"]
 delete_merged_branches = true
 required_approvals = 1
-status = ["continuous-integration/travis-ci/push"]
+status = [
+  "ci-linux (stable, x86_64-unknown-linux-gnu)",
+  "ci-linux (stable, thumbv6m-none-eabi)",
+  "ci-linux (stable, thumbv7m-none-eabi)",
+  "ci-linux (stable, thumbv7em-none-eabi)",
+  "ci-linux (stable, thumbv7em-none-eabihf)",
+  "ci-linux (stable, thumbv8m.main-none-eabi)",
+  "ci-linux (1.39.0, x86_64-unknown-linux-gnu)",
+  "ci-linux (1.39.0, thumbv6m-none-eabi)",
+  "ci-linux (1.39.0, thumbv7m-none-eabi)",
+  "ci-linux (1.39.0, thumbv7em-none-eabi)",
+  "ci-linux (1.39.0, thumbv7em-none-eabihf)",
+  "ci-linux (1.39.0, thumbv8m.main-none-eabi)",
+  "Rustfmt"
+]

cortex-m-rt/.github/workflows/ci.yml

@@ -0,0 +1,39 @@
+on:
+  push:
+    branches: [ staging, trying, master ]
+  pull_request:
+
+name: Continuous integration
+
+jobs:
+  ci-linux:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        # All generated code should be running on stable now
+        rust: [nightly, stable, 1.39.0]
+
+        # The default target we're compiling on and for
+        TARGET: [x86_64-unknown-linux-gnu, thumbv6m-none-eabi, thumbv7m-none-eabi, thumbv7em-none-eabi, thumbv7em-none-eabihf, thumbv8m.main-none-eabi]
+
+        include:
+          # Nightly is only for reference and allowed to fail
+          - rust: nightly
+            experimental: true
+
+    steps:
+      - uses: fiam/arm-none-eabi-gcc@v1
+        with:
+          release: '7-2018-q2'
+      - uses: actions/checkout@v2
+      - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: ${{ matrix.rust }}
+          target: ${{ matrix.TARGET }}
+          override: true
+          components: rustfmt
+      - name: Install qemu
+        run: sudo apt-get install qemu-system-arm
+      - name: Run CI script for ${{ matrix.TARGET }} under ${{ matrix.rust }}
+        run: TARGET=${{ matrix.TARGET }} TRAVIS_RUST_VERSION=${{ matrix.rust }} bash ci/script.sh

cortex-m-rt/.github/workflows/clippy.yml

@@ -0,0 +1,20 @@
+on:
+  push:
+    branches: [ staging, trying, master ]
+  pull_request:
+
+name: Clippy check
+jobs:
+  clippy_check:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: stable
+          override: true
+          components: clippy
+      - uses: actions-rs/clippy-check@v1
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}

cortex-m-rt/.github/workflows/rustfmt.yml

@@ -0,0 +1,23 @@
+on:
+  push:
+    branches: [ staging, trying, master ]
+  pull_request:
+
+name: Code formatting check
+
+jobs:
+  fmt:
+    name: Rustfmt
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: stable
+          override: true
+          components: rustfmt
+      - uses: actions-rs/cargo@v1
+        with:
+          command: fmt
+          args: --all -- --check

cortex-m-rt/.travis.yml

@@ -13,7 +13,8 @@ fn main() {
         fs::copy(
             format!("bin/{}.a", target),
             out_dir.join("libcortex-m-rt.a"),
-        ).unwrap();
+        )
+        .unwrap();
         println!("cargo:rustc-link-lib=static=cortex-m-rt");
     }
 
@@ -34,7 +35,8 @@ fn main() {
 /* Provides weak aliases (cf. PROVIDED) for device specific interrupt handlers */
 /* This will usually be provided by a device crate generated using svd2rust (see `device.x`) */
 INCLUDE device.x"#
-        ).unwrap();
+        )
+        .unwrap();
         f
     } else {
         let mut f = File::create(out.join("link.x")).unwrap();
@@ -55,9 +57,9 @@ INCLUDE device.x"#
         println!("cargo:rustc-cfg=armv8m");
         240
     } else {
-       // Non ARM target. We assume you're just testing the syntax.
-       // This value seems as soon as any
-       240
+        // Non ARM target. We assume you're just testing the syntax.
+        // This value seems as soon as any
+        240
     };
 
     // checking the size of the interrupts portion of the vector table is sub-architecture dependent
@@ -71,7 +73,8 @@ handlers.");
 "#,
         max_int_handlers * 4 + 0x40,
         max_int_handlers
-    ).unwrap();
+    )
+    .unwrap();
 
     println!("cargo:rustc-link-search={}", out.display());
 

cortex-m-rt/build.rs

@@ -13,11 +13,11 @@ use core::ptr;
 use rt::entry;
 
 // This large static array uses most of .rodata
-static RODATA: [u8; 48*1024] = [1u8; 48*1024];
+static RODATA: [u8; 48 * 1024] = [1u8; 48 * 1024];
 
 // This large mutable array causes .data to use the rest of FLASH
 // without also overflowing RAM.
-static mut DATA: [u8; 16*1024] = [1u8; 16*1024];
+static mut DATA: [u8; 16 * 1024] = [1u8; 16 * 1024];
 
 #[entry]
 fn main() -> ! {

cortex-m-rt/ci/install.sh

@@ -8,8 +8,9 @@ fn run_mode(mode: &'static str) {
     config.mode = mode.parse().expect("Invalid mode");
     config.src_base = PathBuf::from(format!("tests/{}", mode));
     // config.link_deps(); // Populate config.target_rustcflags with dependencies on the path
-    config.target_rustcflags =
-        Some("-L target/debug -L target/debug/deps -C panic=abort --cfg feature=\"device\"".to_owned());
+    config.target_rustcflags = Some(
+        "-L target/debug -L target/debug/deps -C panic=abort --cfg feature=\"device\"".to_owned(),
+    );
     // config.clean_rmeta(); // If your tests import the parent crate, this helps with E0464
 
     compiletest::run_tests(&config);