Skip to content

Commit 0cdc55b

Browse files
committed
Explain test a bit
1 parent ab9307f commit 0cdc55b

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

README.md

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,17 @@
11
# aws-sdk-async-response-bytes
22

3-
| | Exclude B | Include B |
4-
|-----------|-----------|-----------|
5-
| Exclude A | 1070 | 787 |
6-
| A1 | 934 | 657 |
7-
| A1+A2 | 644 | 357 |
3+
The test script [`findMinMem.sh`](https://github.com/rtyley/aws-sdk-async-response-bytes/blob/ab9307fee6d4965cce0cba60c439035a22cf2d98/findMinMem.sh)
4+
repeatedly downloads a [**258 MB**](https://github.com/rtyley/aws-sdk-async-response-bytes/blob/eb84c15259f947e91c442eb0b8eda68b8cdbefbb/src/main/java/com/madgag/aws/sdk/async/responsebytes/KnownS3Object.java#L7)
5+
object from S3 into memory, while varying the amount of Java heap memory allocated with `-Xmx`,
6+
to find the amount of memory necessary for the download to consistently succeed.
7+
8+
These are the resulting memory requirements found, in MB, for all possible permutations
9+
of the fixes:
10+
11+
| | Exclude A | A1 | A1+A2 |
12+
|-----------|------------------------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------|
13+
| Exclude B | [1070](https://github.com/rtyley/aws-sdk-async-response-bytes/actions/runs/6058076293#summary-16439864723) | [934](https://github.com/rtyley/aws-sdk-async-response-bytes/actions/runs/6058092753#summary-16439895976) | [644](https://github.com/rtyley/aws-sdk-async-response-bytes/actions/runs/6058095645#summary-16439901557) |
14+
| Include B | [787](https://github.com/rtyley/aws-sdk-async-response-bytes/actions/runs/6058093770#summary-16439898197) | [657](https://github.com/rtyley/aws-sdk-async-response-bytes/actions/runs/6058097434#summary-16439905403) | [357](https://github.com/rtyley/aws-sdk-async-response-bytes/actions/runs/6058098624#summary-16439907698) |
15+
16+
From the results, it's clear that we need all 3 changes (A1, A2, & B) in order
17+
to get the lowest memory usage.

0 commit comments

Comments
 (0)