BUG: Fixed inconsistent multiplication pandas-dev#47953

Author: rsm-23

doc/source/whatsnew/v2.0.3.rst

@@ -21,7 +21,11 @@ Fixed regressions
 
 Bug fixes
 ~~~~~~~~~
+<<<<<<< Updated upstream
 - Bug in :func:`RangeIndex.union` when using ``sort=True`` with another :class:`RangeIndex` (:issue:`53490`)
+=======
+- Bug in :class:`RelativeDeltaOffset` which caused inconsistent behavior upon multiplying a :class:`DateOffset` (:issue:`47953`)
+>>>>>>> Stashed changes
 - Bug in :func:`read_csv` when defining ``dtype`` with ``bool[pyarrow]`` for the ``"c"`` and ``"python"`` engines (:issue:`53390`)
 - Bug in :meth:`Series.str.split` and :meth:`Series.str.rsplit` with ``expand=True`` for :class:`ArrowDtype` with ``pyarrow.string`` (:issue:`53532`)
 -

pandas/_libs/tslibs/offsets.pyx

@@ -1221,15 +1221,14 @@ cdef class RelativeDeltaOffset(BaseOffset):
                 # perform calculation in UTC
                 other = other.replace(tzinfo=None)
 
-            if self.n > 0:
-                for i in range(self.n):
-                    other = other + self._offset
+            if hasattr(self, "nanoseconds"):
+                td_nano = Timedelta(nanoseconds=self.nanoseconds)
+                other = self.n * td_nano + other
             else:
-                for i in range(-self.n):
-                    other = other - self._offset
+                td_nano = Timedelta(0)
+
+            other = other + ((self.offset + td_nano) * self.n)
 
-            if hasattr(self, "nanoseconds"):
-                other = self.n * Timedelta(nanoseconds=self.nanoseconds) + other
             if other_nanos != 0:
                 other = Timedelta(nanoseconds=other_nanos) + other
 

pandas/tests/tseries/offsets/test_offsets.py

@@ -32,6 +32,7 @@
 from pandas.errors import PerformanceWarning
 
 from pandas import (
+    DataFrame,
     DatetimeIndex,
     Series,
     date_range,
@@ -1075,3 +1076,44 @@ def test_dateoffset_add_sub_timestamp_series_with_nano(offset, expected):
     assert testseries[0] == teststamp
     testseries = offset + testseries
     assert testseries[0] == expected
+
+
+@pytest.mark.parametrize(
+    "month_value, scaling_factor, start_timestamp, expected_timestamp",
+    [(1, 2, "2020-01-30", "2020-03-30"), (2, 1, "2020-01-30", "2020-03-30")],
+)
+def test_offset_multiplication(
+    month_value, scaling_factor, start_timestamp, expected_timestamp
+):
+    # GH 47953
+    mo1 = DateOffset(months=month_value)
+
+    startscalar = Timestamp(start_timestamp)
+    startarray = Series([startscalar])
+
+    resultscalar = startscalar + (mo1 * scaling_factor)
+    resultarray = startarray + (mo1 * scaling_factor)
+
+    expectedscalar = Timestamp(expected_timestamp)
+    expectedarray = Series([expectedscalar])
+    assert resultscalar == expectedscalar
+
+    tm.assert_series_equal(resultarray, expectedarray)
+
+
+def test_dateoffset_operations_on_dataframes():
+    # GH 47953
+    df = DataFrame({"T": [Timestamp("2019-04-30")], "D": [DateOffset(months=1)]})
+    frameresult1 = df["T"] + 26 * df["D"]
+    df2 = DataFrame(
+        {
+            "T": [Timestamp("2019-04-30"), Timestamp("2019-04-30")],
+            "D": [DateOffset(months=1), DateOffset(months=1)],
+        }
+    )
+    expecteddate = Timestamp("2021-06-30")
+    with tm.assert_produces_warning(PerformanceWarning):
+        frameresult2 = df2["T"] + 26 * df2["D"]
+
+    assert frameresult1[0] == expecteddate
+    assert frameresult2[0] == expecteddate