CLN: move set_grouper/get_grouper type pd.Grouper methods to internal

Author: jreback

pandas/core/groupby.py

@@ -198,7 +198,7 @@ def __init__(self, key=None, level=None, freq=None, axis=None, sort=False):
     def ax(self):
         return self.grouper
 
-    def get_grouper(self, obj):
+    def _get_grouper(self, obj):
 
         """
         Parameters
@@ -210,10 +210,10 @@ def get_grouper(self, obj):
         a tuple of binner, grouper, obj (possibly sorted)
         """
 
-        self.set_grouper(obj)
+        self._set_grouper(obj)
         return self.binner, self.grouper, self.obj
 
-    def set_grouper(self, obj, sort=False):
+    def _set_grouper(self, obj, sort=False):
         """
         given an object and the specifcations, setup the internal grouper for this particular specification
 
@@ -264,7 +264,7 @@ def set_grouper(self, obj, sort=False):
         self.grouper = ax
         return self.grouper
 
-    def get_binner_for_grouping(self, obj):
+    def _get_binner_for_grouping(self, obj):
         raise NotImplementedError
 
     @property
@@ -1697,7 +1697,7 @@ def __init__(self, index, grouper=None, obj=None, name=None, level=None,
             elif isinstance(self.grouper, Grouper):
 
                 # get the new grouper
-                grouper = self.grouper.get_binner_for_grouping(self.obj)
+                grouper = self.grouper._get_binner_for_grouping(self.obj)
                 self.obj = self.grouper.obj
                 self.grouper = grouper
                 if self.name is None:
@@ -1807,7 +1807,7 @@ def _get_grouper(obj, key=None, axis=0, level=None, sort=True):
 
     # a passed in Grouper, directly convert
     if isinstance(key, Grouper):
-        binner, grouper, obj = key.get_grouper(obj)
+        binner, grouper, obj = key._get_grouper(obj)
         return grouper, [], obj
 
     # already have a BaseGrouper, just return it

pandas/tseries/resample.py

@@ -76,7 +76,7 @@ def __init__(self, freq='Min', closed=None, label=None, how='mean',
         super(TimeGrouper, self).__init__(freq=freq, axis=axis, **kwargs)
 
     def resample(self, obj):
-        self.set_grouper(obj, sort=True)
+        self._set_grouper(obj, sort=True)
         ax = self.grouper
 
         if isinstance(ax, DatetimeIndex):
@@ -93,7 +93,7 @@ def resample(self, obj):
                 rs = self._resample_periods()
             else:
                 obj = self.obj.to_timestamp(how=self.convention)
-                self.set_grouper(obj)
+                self._set_grouper(obj)
                 rs = self._resample_timestamps()
         elif len(ax) == 0:
             return self.obj
@@ -104,11 +104,11 @@ def resample(self, obj):
         rs_axis.name = ax.name
         return rs
 
-    def get_grouper(self, obj):
-        self.set_grouper(obj)
-        return self.get_binner_for_resample()
+    def _get_grouper(self, obj):
+        self._set_grouper(obj)
+        return self._get_binner_for_resample()
 
-    def get_binner_for_resample(self):
+    def _get_binner_for_resample(self):
         # create the BinGrouper
         # assume that self.set_grouper(obj) has already been called
 
@@ -121,12 +121,12 @@ def get_binner_for_resample(self):
         self.grouper = BinGrouper(bins, binlabels)
         return self.binner, self.grouper, self.obj
 
-    def get_binner_for_grouping(self, obj):
+    def _get_binner_for_grouping(self, obj):
         # return an ordering of the transformed group labels,
         # suitable for multi-grouping, e.g the labels for
         # the resampled intervals
-        ax = self.set_grouper(obj)
-        self.get_binner_for_resample()
+        ax = self._set_grouper(obj)
+        self._get_binner_for_resample()
 
         # create the grouper
         binner = self.binner
@@ -233,7 +233,7 @@ def _resample_timestamps(self):
         # assumes set_grouper(obj) already called
         axlabels = self.ax
 
-        self.get_binner_for_resample()
+        self._get_binner_for_resample()
         grouper = self.grouper
         binner = self.binner
         obj = self.obj

pandas/tseries/tests/test_resample.py

@@ -1134,7 +1134,7 @@ def test_apply_iteration(self):
         df = DataFrame({'open': 1, 'close': 2}, index=ind)
         tg = TimeGrouper('M')
 
-        _, grouper, _ = tg.get_grouper(df)
+        _, grouper, _ = tg._get_grouper(df)
 
         # Errors
         grouped = df.groupby(grouper, group_keys=False)
@@ -1151,7 +1151,7 @@ def test_panel_aggregation(self):
                       minor_axis=['A', 'B', 'C', 'D'])
 
         tg = TimeGrouper('M', axis=1)
-        _, grouper, _ = tg.get_grouper(wp)
+        _, grouper, _ = tg._get_grouper(wp)
         bingrouped = wp.groupby(grouper)
         binagg = bingrouped.mean()