Apply advices from clippy

Signed-off-by: Taehun Lim <[email protected]>

Author: routiful

rclrs/src/dynamic_message.rs

@@ -75,7 +75,7 @@ fn get_type_support_library(
     let ament = ament_rs::Ament::new().map_err(|_| RequiredPrefixNotSourced {
         package: package_name.to_owned(),
     })?;
-    let prefix = PathBuf::from(ament.find_package(&package_name).ok_or(
+    let prefix = PathBuf::from(ament.find_package(package_name).ok_or(
         RequiredPrefixNotSourced {
             package: package_name.to_owned(),
         },

rclrs/src/error.rs

@@ -347,6 +347,6 @@ pub(crate) trait ToResult {
 
 impl ToResult for rcl_ret_t {
     fn ok(&self) -> Result<(), RclrsError> {
-        to_rclrs_result(*self as i32)
+        to_rclrs_result(*self)
     }
 }

rclrs/src/node.rs

@@ -173,7 +173,7 @@ impl Node {
         &self,
         getter: unsafe extern "C" fn(*const rcl_node_t) -> *const c_char,
     ) -> String {
-        unsafe { call_string_getter_with_handle(&*self.rcl_node_mtx.lock().unwrap(), getter) }
+        unsafe { call_string_getter_with_handle(&self.rcl_node_mtx.lock().unwrap(), getter) }
     }
 
     /// Creates a [`Client`][1].
@@ -317,7 +317,7 @@ impl Node {
     }
 
     /// Returns the ROS domain ID that the node is using.
-    ///    
+    ///
     /// The domain ID controls which nodes can send messages to each other, see the [ROS 2 concept article][1].
     /// It can be set through the `ROS_DOMAIN_ID` environment variable.
     ///

rclrs/src/parameter/value.rs

@@ -163,8 +163,8 @@ mod tests {
             assert!(!rcl_params.is_null());
             assert_eq!(unsafe { (*rcl_params).num_nodes }, 1);
             let rcl_node_params = unsafe { &(*(*rcl_params).params) };
-            assert_eq!((*rcl_node_params).num_params, 1);
-            let rcl_variant = unsafe { &(*(*rcl_node_params).parameter_values) };
+            assert_eq!(rcl_node_params.num_params, 1);
+            let rcl_variant = unsafe { &(*rcl_node_params.parameter_values) };
             let param_value = unsafe { ParameterValue::from_rcl_variant(rcl_variant) };
             assert_eq!(param_value, pair.1);
             unsafe { rcl_yaml_node_struct_fini(rcl_params) };

rclrs/src/subscription.rs

@@ -183,7 +183,7 @@ where
     ///
     /// This can be more efficient for messages containing large arrays.
     pub fn take_boxed(&self) -> Result<(Box<T>, MessageInfo), RclrsError> {
-        let mut rmw_message = Box::new(<T as Message>::RmwMsg::default());
+        let mut rmw_message = Box::<<T as Message>::RmwMsg>::default();
         let message_info = self.take_inner(&mut *rmw_message)?;
         // TODO: This will still use the stack in general. Change signature of
         // from_rmw_message to allow placing the result in a Box directly.