Skip to content

Commit b7fd980

Browse files
Addressing Heitor feedback
1 parent b69f098 commit b7fd980

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

aws_lambda_powertools/utilities/data_classes/secrets_manager_event.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,12 @@ def secret_id(self) -> str:
1111

1212
@property
1313
def client_request_token(self) -> str:
14-
"""ClientRequestToken: The ClientRequestToken of the secret version"""
14+
"""ClientRequestToken: The ClientRequestToken associated with the secret version"""
15+
return self["ClientRequestToken"]
16+
17+
@property
18+
def version_id(self) -> str:
19+
"""Alias to ClientRequestToken to get token associated to version"""
1520
return self["ClientRequestToken"]
1621

1722
@property

examples/event_sources/src/secrets_manager.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
def lambda_handler(event: SecretsManagerEvent, context):
99
# Getting secret value using Parameter utility
1010
# See https://docs.powertools.aws.dev/lambda/python/latest/utilities/parameters/
11-
secret = secrets_provider.get(event.secret_id, VersionId=event.client_request_token, VersionStage="AWSCURRENT")
11+
secret = secrets_provider.get(event.secret_id, VersionId=event.version_id, VersionStage="AWSCURRENT")
1212

1313
# You need to work with secrets afterwards
1414
# Check more examples: https://github.com/aws-samples/aws-secrets-manager-rotation-lambdas

tests/unit/data_classes/test_secrets_manager_event.py

+1
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,5 @@ def test_secrets_manager_event():
88

99
assert parsed_event.secret_id == raw_event["SecretId"]
1010
assert parsed_event.client_request_token == raw_event["ClientRequestToken"]
11+
assert parsed_event.version_id == raw_event["ClientRequestToken"]
1112
assert parsed_event.step == raw_event["Step"]

0 commit comments

Comments
 (0)