Skip to content

Commit abf6a93

Browse files
committed
address typo, example fixes
1 parent 790f6ba commit abf6a93

File tree

5 files changed

+21
-13
lines changed

5 files changed

+21
-13
lines changed

aws_lambda_powertools/utilities/data_classes/__init__.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
from .kinesis_stream_event import KinesisStreamEvent
1919
from .lambda_function_url_event import LambdaFunctionUrlEvent
2020
from .s3_event import S3Event, S3EventBridgeNotificationEvent
21-
from .secrets_event import SecretManagerEvent
21+
from .secrets_manager_event import SecretsManagerEvent
2222
from .ses_event import SESEvent
2323
from .sns_event import SNSEvent
2424
from .sqs_event import SQSEvent
@@ -27,7 +27,7 @@
2727
__all__ = [
2828
"APIGatewayProxyEvent",
2929
"APIGatewayProxyEventV2",
30-
"SecretManagerEvent",
30+
"SecretsManagerEvent",
3131
"AppSyncResolverEvent",
3232
"ALBEvent",
3333
"CloudWatchDashboardCustomWidgetEvent",

aws_lambda_powertools/utilities/data_classes/secrets_event.py renamed to aws_lambda_powertools/utilities/data_classes/secrets_manager_event.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from aws_lambda_powertools.utilities.data_classes.common import DictWrapper
44

55

6-
class SecretManagerEvent(DictWrapper):
6+
class SecretsManagerEvent(DictWrapper):
77
@property
88
def secret_id(self) -> str:
99
"""SecretId: The secret ARN or identifier"""

docs/utilities/data_classes.md

+14-6
Original file line numberDiff line numberDiff line change
@@ -1166,19 +1166,27 @@ You can register your Lambda functions as targets within an Amazon VPC Lattice s
11661166
=== "app.py"
11671167

11681168
```python
1169-
from aws_lambda_powertools.utilities.data_classes import event_source, SecretManagerEvent
1169+
import boto3
11701170

1171-
@event_source(data_class=SecretManagerEvent)
1172-
def lambda_handler(event: SecretManagerEvent, context):
1173-
# Multiple records can be delivered in a single event
1171+
from aws_lambda_powertools.utilities.data_classes import event_source, SecretsManagerEvent
1172+
1173+
@event_source(data_class=SecretsManagerEvent)
1174+
def lambda_handler(event: SecretsManagerEvent, context):
11741175
service_client = boto3.client('secretsmanager', endpoint_url=os.environ['SECRETS_MANAGER_ENDPOINT'])
1175-
create_secret(service_client, event.secret_id, event.client_request_token)
1176+
secret = service_client.get_secret_value(
1177+
SecretId=event.secret_id,
1178+
VersionId=event.client_request_token,
1179+
VersionStage="AWSCURRENT"
1180+
)
1181+
# {'Name': 'MyTestDatabaseSecret','SecretString': '{\n "username":"david",\n "password":"EXAMPLE-PASSWORD"\n}\n',}
1182+
# work with secrets afterwards
1183+
# see - https://github.com/aws-samples/aws-secrets-manager-rotation-lambdas
11761184
...
11771185
```
11781186
=== "Secrets Manager Example Event"
11791187

11801188
```json
1181-
--8<-- "tests/events/secretManagerEvent.json"
1189+
--8<-- "tests/events/secretsManagerEvent.json"
11821190
```
11831191

11841192
## Advanced

tests/unit/data_classes/test_secret_event.py renamed to tests/unit/data_classes/test_secrets_manager_event.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
from aws_lambda_powertools.utilities.data_classes.secrets_event import SecretManagerEvent
1+
from aws_lambda_powertools.utilities.data_classes.secrets_manager_event import SecretsManagerEvent
22
from tests.functional.utils import load_event
33

44

5-
def test_vpc_lattice_event():
6-
raw_event = load_event("secretManagerEvent.json")
7-
parsed_event = SecretManagerEvent(raw_event)
5+
def test_secrets_manager_event():
6+
raw_event = load_event("secretsManagerEvent.json")
7+
parsed_event = SecretsManagerEvent(raw_event)
88

99
assert parsed_event.secret_id == raw_event["SecretId"]
1010
assert parsed_event.client_request_token == raw_event["ClientRequestToken"]

0 commit comments

Comments
 (0)