Skip to content

Commit 06c9c8e

Browse files
committed
fix static checking error
1 parent b9f8cea commit 06c9c8e

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

aws_lambda_powertools/metrics/provider/base.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
logger = logging.getLogger(__name__)
77

8+
is_cold_start = True
9+
810

911
class MetricsProviderBase(ABC):
1012
"""Class for metric provider template

aws_lambda_powertools/metrics/provider/datadog_provider_draft.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
# Check if using layer
1616
try:
17-
from datadog import lambda_metric
17+
from datadog_lambda.metric import lambda_metric
1818
except ImportError:
1919
lambda_metric = None
2020

@@ -28,7 +28,7 @@ def __init__(self, namespace):
2828
super().__init__()
2929

3030
# adding timestamp, tags. unit, resolution, name will not be used
31-
def add_metric(self, name, value, timestamp, tag: List = None):
31+
def add_metric(self, name: str, value: float, timestamp: float, tag: List):
3232
if not isinstance(value, numbers.Real):
3333
raise MetricValueError(f"{value} is not a valid number")
3434
if not timestamp:
@@ -38,8 +38,8 @@ def add_metric(self, name, value, timestamp, tag: List = None):
3838
# serialize for flushing
3939
def serialize(self) -> Dict:
4040
# logic here is to add dimension and metadata to each metric's tag with "key:value" format
41-
extra_tags = []
42-
output_list = []
41+
extra_tags: List = []
42+
output_list: List = []
4343

4444
for single_metric in self.metrics:
4545
output_list.append(
@@ -81,7 +81,7 @@ def __init__(self, provider):
8181
self.provider = provider
8282
super().__init__()
8383

84-
def add_metric(self, name: str, value: float, timestamp: time, tags: List = None):
84+
def add_metric(self, name: str, value: float, timestamp: float, tags: List):
8585
self.provider.add_metric(name, value, timestamp, tags)
8686

8787
def flush_metrics(self, raise_on_empty_metrics: bool = False) -> None:

0 commit comments

Comments
 (0)