- allow step to be 0 for ValuesIterator

rocketlaunchr-cto · rocketlaunchr-cto · commit 1713e5c86225 · 2021-10-25T16:15:21.000+11:00
diff --git a/dataframe.go b/dataframe.go
@@ -166,9 +166,8 @@ func (df *DataFrame) ValuesIterator(opts ...ValuesOptions) func(opts ...SeriesRe
 		if row < 0 {
 			row = df.n + row
 		}
-		step = opts[0].Step
-		if step == 0 {
-			panic("Step can not be zero")
+		if opts[0].Step != 0 {
+			step = opts[0].Step
 		}
 	}
 
diff --git a/series_float64.go b/series_float64.go
@@ -309,9 +309,8 @@ func (s *SeriesFloat64) ValuesIterator(opts ...ValuesOptions) func() (*int, inte
 		if row < 0 {
 			row = len(s.Values) + row
 		}
-		step = opts[0].Step
-		if step == 0 {
-			panic("Step can not be zero")
+		if opts[0].Step != 0 {
+			step = opts[0].Step
 		}
 	}
 
diff --git a/series_generic.go b/series_generic.go
@@ -285,9 +285,8 @@ func (s *SeriesGeneric) ValuesIterator(opts ...ValuesOptions) func() (*int, inte
 		if row < 0 {
 			row = len(s.values) + row
 		}
-		step = opts[0].Step
-		if step == 0 {
-			panic("Step can not be zero")
+		if opts[0].Step != 0 {
+			step = opts[0].Step
 		}
 	}
 
diff --git a/series_int64.go b/series_int64.go
@@ -303,9 +303,8 @@ func (s *SeriesInt64) ValuesIterator(opts ...ValuesOptions) func() (*int, interf
 		if row < 0 {
 			row = len(s.values) + row
 		}
-		step = opts[0].Step
-		if step == 0 {
-			panic("Step can not be zero")
+		if opts[0].Step != 0 {
+			step = opts[0].Step
 		}
 	}
 
diff --git a/series_mixed.go b/series_mixed.go
@@ -305,9 +305,8 @@ func (s *SeriesMixed) ValuesIterator(opts ...ValuesOptions) func() (*int, interf
 		if row < 0 {
 			row = len(s.values) + row
 		}
-		step = opts[0].Step
-		if step == 0 {
-			panic("Step can not be zero")
+		if opts[0].Step != 0 {
+			step = opts[0].Step
 		}
 	}
 
diff --git a/series_string.go b/series_string.go
@@ -302,9 +302,8 @@ func (s *SeriesString) ValuesIterator(opts ...ValuesOptions) func() (*int, inter
 		if row < 0 {
 			row = len(s.values) + row
 		}
-		step = opts[0].Step
-		if step == 0 {
-			panic("Step can not be zero")
+		if opts[0].Step != 0 {
+			step = opts[0].Step
 		}
 	}
 
diff --git a/series_time.go b/series_time.go
@@ -314,9 +314,8 @@ func (s *SeriesTime) ValuesIterator(opts ...ValuesOptions) func() (*int, interfa
 		if row < 0 {
 			row = len(s.Values) + row
 		}
-		step = opts[0].Step
-		if step == 0 {
-			panic("Step can not be zero")
+		if opts[0].Step != 0 {
+			step = opts[0].Step
 		}
 	}
 
diff --git a/xseries/series_complex128.go b/xseries/series_complex128.go
@@ -317,9 +317,8 @@ func (s *SeriesComplex128) ValuesIterator(opts ...dataframe.ValuesOptions) func(
 		if row < 0 {
 			row = len(s.Values) + row
 		}
-		step = opts[0].Step
-		if step == 0 {
-			panic("Step can not be zero")
+		if opts[0].Step != 0 {
+			step = opts[0].Step
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -166,9 +166,8 @@ func (df *DataFrame) ValuesIterator(opts ...ValuesOptions) func(opts ...SeriesRe`
`166`	`166`	`if row < 0 {`
`167`	`167`	`row = df.n + row`
`168`	`168`	`}`
`169`		`- step = opts[0].Step`
`170`		`- if step == 0 {`
`171`		`- panic("Step can not be zero")`
	`169`	`+ if opts[0].Step != 0 {`
	`170`	`+ step = opts[0].Step`
`172`	`171`	`}`
`173`	`172`	`}`
`174`	`173`
Original file line number	Diff line number	Diff line change
`@@ -309,9 +309,8 @@ func (s SeriesFloat64) ValuesIterator(opts ...ValuesOptions) func() (int, inte`
`309`	`309`	`if row < 0 {`
`310`	`310`	`row = len(s.Values) + row`
`311`	`311`	`}`
`312`		`- step = opts[0].Step`
`313`		`- if step == 0 {`
`314`		`- panic("Step can not be zero")`
	`312`	`+ if opts[0].Step != 0 {`
	`313`	`+ step = opts[0].Step`
`315`	`314`	`}`
`316`	`315`	`}`
`317`	`316`
Original file line number	Diff line number	Diff line change
`@@ -285,9 +285,8 @@ func (s SeriesGeneric) ValuesIterator(opts ...ValuesOptions) func() (int, inte`
`285`	`285`	`if row < 0 {`
`286`	`286`	`row = len(s.values) + row`
`287`	`287`	`}`
`288`		`- step = opts[0].Step`
`289`		`- if step == 0 {`
`290`		`- panic("Step can not be zero")`
	`288`	`+ if opts[0].Step != 0 {`
	`289`	`+ step = opts[0].Step`
`291`	`290`	`}`
`292`	`291`	`}`
`293`	`292`
Original file line number	Diff line number	Diff line change
`@@ -303,9 +303,8 @@ func (s SeriesInt64) ValuesIterator(opts ...ValuesOptions) func() (int, interf`
`303`	`303`	`if row < 0 {`
`304`	`304`	`row = len(s.values) + row`
`305`	`305`	`}`
`306`		`- step = opts[0].Step`
`307`		`- if step == 0 {`
`308`		`- panic("Step can not be zero")`
	`306`	`+ if opts[0].Step != 0 {`
	`307`	`+ step = opts[0].Step`
`309`	`308`	`}`
`310`	`309`	`}`
`311`	`310`
Original file line number	Diff line number	Diff line change
`@@ -305,9 +305,8 @@ func (s SeriesMixed) ValuesIterator(opts ...ValuesOptions) func() (int, interf`
`305`	`305`	`if row < 0 {`
`306`	`306`	`row = len(s.values) + row`
`307`	`307`	`}`
`308`		`- step = opts[0].Step`
`309`		`- if step == 0 {`
`310`		`- panic("Step can not be zero")`
	`308`	`+ if opts[0].Step != 0 {`
	`309`	`+ step = opts[0].Step`
`311`	`310`	`}`
`312`	`311`	`}`
`313`	`312`
Original file line number	Diff line number	Diff line change
`@@ -302,9 +302,8 @@ func (s SeriesString) ValuesIterator(opts ...ValuesOptions) func() (int, inter`
`302`	`302`	`if row < 0 {`
`303`	`303`	`row = len(s.values) + row`
`304`	`304`	`}`
`305`		`- step = opts[0].Step`
`306`		`- if step == 0 {`
`307`		`- panic("Step can not be zero")`
	`305`	`+ if opts[0].Step != 0 {`
	`306`	`+ step = opts[0].Step`
`308`	`307`	`}`
`309`	`308`	`}`
`310`	`309`
Original file line number	Diff line number	Diff line change
`@@ -314,9 +314,8 @@ func (s SeriesTime) ValuesIterator(opts ...ValuesOptions) func() (int, interfa`
`314`	`314`	`if row < 0 {`
`315`	`315`	`row = len(s.Values) + row`
`316`	`316`	`}`
`317`		`- step = opts[0].Step`
`318`		`- if step == 0 {`
`319`		`- panic("Step can not be zero")`
	`317`	`+ if opts[0].Step != 0 {`
	`318`	`+ step = opts[0].Step`
`320`	`319`	`}`
`321`	`320`	`}`
`322`	`321`
Original file line number	Diff line number	Diff line change
`@@ -317,9 +317,8 @@ func (s *SeriesComplex128) ValuesIterator(opts ...dataframe.ValuesOptions) func(`
`317`	`317`	`if row < 0 {`
`318`	`318`	`row = len(s.Values) + row`
`319`	`319`	`}`
`320`		`- step = opts[0].Step`
`321`		`- if step == 0 {`
`322`		`- panic("Step can not be zero")`
	`320`	`+ if opts[0].Step != 0 {`
	`321`	`+ step = opts[0].Step`
`323`	`322`	`}`
`324`	`323`	`}`
`325`	`324`