Skip to content

Commit f66daf6

Browse files
nirrozenbaumrlakhtakia
authored andcommitted
remove EndpointSlice from RBAC (kubernetes-sigs#774)
Signed-off-by: Nir Rozenbaum <[email protected]>
1 parent 9be60d8 commit f66daf6

File tree

3 files changed

+7
-13
lines changed

3 files changed

+7
-13
lines changed

config/manifests/inferencepool-resources.yaml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,18 +86,15 @@ apiVersion: rbac.authorization.k8s.io/v1
8686
metadata:
8787
name: pod-read
8888
rules:
89+
- apiGroups: ["inference.networking.x-k8s.io"]
90+
resources: ["inferencepools"]
91+
verbs: ["get", "watch", "list"]
8992
- apiGroups: ["inference.networking.x-k8s.io"]
9093
resources: ["inferencemodels"]
9194
verbs: ["get", "watch", "list"]
9295
- apiGroups: [""]
9396
resources: ["pods"]
9497
verbs: ["get", "watch", "list"]
95-
- apiGroups: ["inference.networking.x-k8s.io"]
96-
resources: ["inferencepools"]
97-
verbs: ["get", "watch", "list"]
98-
- apiGroups: ["discovery.k8s.io"]
99-
resources: ["endpointslices"]
100-
verbs: ["get", "watch", "list"]
10198
- apiGroups:
10299
- authentication.k8s.io
103100
resources:

pkg/epp/server/runserver.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ func (r *ExtProcServerRunner) SetupWithManager(ctx context.Context, mgr ctrl.Man
104104
Client: mgr.GetClient(),
105105
Record: mgr.GetEventRecorderFor("pod"),
106106
}).SetupWithManager(mgr); err != nil {
107-
return fmt.Errorf("failed setting up EndpointSliceReconciler: %v", err)
107+
return fmt.Errorf("failed setting up PodReconciler: %v", err)
108108
}
109109
return nil
110110
}

test/testdata/inferencepool-e2e.yaml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,18 +88,15 @@ apiVersion: rbac.authorization.k8s.io/v1
8888
metadata:
8989
name: pod-read
9090
rules:
91+
- apiGroups: ["inference.networking.x-k8s.io"]
92+
resources: ["inferencepools"]
93+
verbs: ["get", "watch", "list"]
9194
- apiGroups: ["inference.networking.x-k8s.io"]
9295
resources: ["inferencemodels"]
9396
verbs: ["get", "watch", "list"]
9497
- apiGroups: [""]
9598
resources: ["pods"]
9699
verbs: ["get", "watch", "list"]
97-
- apiGroups: ["inference.networking.x-k8s.io"]
98-
resources: ["inferencepools"]
99-
verbs: ["get", "watch", "list"]
100-
- apiGroups: ["discovery.k8s.io"]
101-
resources: ["endpointslices"]
102-
verbs: ["get", "watch", "list"]
103100
- apiGroups:
104101
- authentication.k8s.io
105102
resources:

0 commit comments

Comments
 (0)