Skip to content

Commit 18e7d86

Browse files
committed
fix(event-names): fix event name linting in sendTo and forwardTo action creators
fix #22
1 parent dcd50f1 commit 18e7d86

File tree

2 files changed

+48
-1
lines changed

2 files changed

+48
-1
lines changed

lib/rules/event-names.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ module.exports = {
161161
},
162162

163163
[selectorSendEvent(prefix)]: function (node) {
164-
const eventArg = node.arguments[0]
164+
const eventArg = (['sendTo', 'forwardTo'].includes(node.callee.name)) ? node.arguments[1] : node.arguments[0]
165165
if (!eventArg) {
166166
return
167167
}

tests/lib/rules/event-names.js

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ const tests = {
1919
sendParent('MOUSE.CLICK'),
2020
raise('MY_MOUSE.SCROLL_DOWN'),
2121
send({ type: 'TOGGLE' }),
22+
sendTo('myActor', 'TOGGLE'),
23+
sendTo('myActor', { type: 'TOGGLE' }),
24+
forwardTo('myActor'),
2225
],
2326
})
2427
`,
@@ -71,6 +74,8 @@ const tests = {
7174
respond('My Event'),
7275
raise('myEvent.click'),
7376
send({ type: 'myEvent' }),
77+
sendTo('myActor', 'myEvent2'),
78+
sendTo('myActor', { type: 'myEvent3' }),
7479
],
7580
})
7681
`,
@@ -114,6 +119,14 @@ const tests = {
114119
messageId: 'invalidEventName',
115120
data: { eventName: 'myEvent', fixedEventName: 'MY_EVENT' },
116121
},
122+
{
123+
messageId: 'invalidEventName',
124+
data: { eventName: 'myEvent2', fixedEventName: 'MY_EVENT_2' },
125+
},
126+
{
127+
messageId: 'invalidEventName',
128+
data: { eventName: 'myEvent3', fixedEventName: 'MY_EVENT_3' },
129+
},
117130
],
118131
output: `
119132
createMachine({
@@ -129,6 +142,8 @@ const tests = {
129142
respond('MY_EVENT'),
130143
raise('MY_EVENT.CLICK'),
131144
send({ type: 'MY_EVENT' }),
145+
sendTo('myActor', 'MY_EVENT_2'),
146+
sendTo('myActor', { type: 'MY_EVENT_3' }),
132147
],
133148
})
134149
`,
@@ -150,6 +165,8 @@ const tests = {
150165
respond('My Event'),
151166
raise('myEvent.click'),
152167
send({ type: 'myEvent' }),
168+
sendTo('myActor', 'myEvent2'),
169+
sendTo('myActor', { type: 'myEvent3' }),
153170
],
154171
})
155172
`,
@@ -193,6 +210,14 @@ const tests = {
193210
messageId: 'invalidEventName',
194211
data: { eventName: 'myEvent', fixedEventName: 'my_event' },
195212
},
213+
{
214+
messageId: 'invalidEventName',
215+
data: { eventName: 'myEvent2', fixedEventName: 'my_event_2' },
216+
},
217+
{
218+
messageId: 'invalidEventName',
219+
data: { eventName: 'myEvent3', fixedEventName: 'my_event_3' },
220+
},
196221
],
197222
output: `
198223
/* eslint event-names: [ "warn", "snakeCase" ] */
@@ -209,6 +234,8 @@ const tests = {
209234
respond('my_event'),
210235
raise('my_event.click'),
211236
send({ type: 'my_event' }),
237+
sendTo('myActor', 'my_event_2'),
238+
sendTo('myActor', { type: 'my_event_3' }),
212239
],
213240
})
214241
`,
@@ -230,6 +257,8 @@ const tests = {
230257
respond('My Event'),
231258
raise('my_event.click'),
232259
send({ type: 'my_event' }),
260+
sendTo('myActor', 'my_event_2'),
261+
sendTo('myActor', { type: 'my_event_3' }),
233262
],
234263
})
235264
`,
@@ -273,6 +302,14 @@ const tests = {
273302
messageId: 'invalidEventName',
274303
data: { eventName: 'my_event', fixedEventName: 'myEvent' },
275304
},
305+
{
306+
messageId: 'invalidEventName',
307+
data: { eventName: 'my_event_2', fixedEventName: 'myEvent2' },
308+
},
309+
{
310+
messageId: 'invalidEventName',
311+
data: { eventName: 'my_event_3', fixedEventName: 'myEvent3' },
312+
},
276313
],
277314
output: `
278315
/* eslint event-names: [ "warn", "camelCase" ] */
@@ -289,6 +326,8 @@ const tests = {
289326
respond('myEvent'),
290327
raise('myEvent.click'),
291328
send({ type: 'myEvent' }),
329+
sendTo('myActor', 'myEvent2'),
330+
sendTo('myActor', { type: 'myEvent3' }),
292331
],
293332
})
294333
`,
@@ -303,6 +342,8 @@ const tests = {
303342
respond('*'),
304343
raise('EVENT.*'),
305344
send({ type: 'EVENT.*' }),
345+
sendTo('myActor', 'EVENT.*'),
346+
sendTo('myActor', { type: 'EVENT.*' }),
306347
],
307348
})
308349
`,
@@ -322,6 +363,12 @@ const tests = {
322363
{
323364
messageId: 'invalidSendEventName',
324365
},
366+
{
367+
messageId: 'invalidSendEventName',
368+
},
369+
{
370+
messageId: 'invalidSendEventName',
371+
},
325372
],
326373
},
327374
{

0 commit comments

Comments
 (0)