Skip to content

Chapter 01, error in plot in cell 17 #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hassec opened this issue Jun 26, 2020 · 2 comments
Closed

Chapter 01, error in plot in cell 17 #343

hassec opened this issue Jun 26, 2020 · 2 comments

Comments

@hassec
Copy link
Contributor

hassec commented Jun 26, 2020

I think the plot in cell 17 in chapter 01, has a slight error.
The text states an initialization of the filter of weight=160 and that weighing starts on day 1.
Yet the plot shows the measurements starting at day zero.
I think it's simply a mistake that the measurements aren't plotted with an x-axis offset of 1 day, as is done for the predictions.
Then the plot would also make more sense in the way that a measurement results in an estimate between measurement and prediction.

Happy to make a PR, if you wish.

@MichaelHay42
Copy link

I agree the 1-day offset threw me off too

rlabbe added a commit that referenced this issue Oct 13, 2020
Measurements were being plotted off by one (day 0 instead of the
correct day 1).
@rlabbe
Copy link
Owner

rlabbe commented Oct 13, 2020

fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants