Add static null logger

Author: rjmholt

src/PowerShellEditorServices/Utility/Logging.cs

@@ -145,21 +145,24 @@ public PsesLogger Build()
         }
 
         /// <summary>
-        /// Contruct a logger with the applied configuration.
+        /// A do-nothing logger that simply discards messages.
         /// </summary>
-        /// <returns>The constructed logger.</returns>
-        public static Builder CreateLogger()
+        public static PsesLogger NullLogger
         {
-            return new Builder();
+            get
+            {
+                return s_nullLogger ?? (s_nullLogger = CreateLogger().Build());
+            }
         }
+        private static PsesLogger s_nullLogger;
 
         /// <summary>
-        /// Create a No-Op logger, which just throws away log messages.
+        /// Contruct a logger with the applied configuration.
         /// </summary>
-        /// <returns>A do-nothing logger, with no output anywhere.</returns>
-        public static PsesLogger CreateNullLogger()
+        /// <returns>The constructed logger.</returns>
+        public static Builder CreateLogger()
         {
-            return CreateLogger().Build();
+            return new Builder();
         }
 
         /// <summary>

test/PowerShellEditorServices.Test.Protocol/Message/MessageReaderWriterTests.cs

@@ -25,7 +25,7 @@ public class MessageReaderWriterTests
 
         public MessageReaderWriterTests()
         {
-            this.logger = Logging.CreateLogger().Build();
+            this.logger = Logging.NullLogger;
             this.messageSerializer = new V8MessageSerializer();
         }
 

test/PowerShellEditorServices.Test/Console/ChoicePromptHandlerTests.cs

@@ -96,7 +96,7 @@ internal class TestChoicePromptHandler : ChoicePromptHandler
 
         public int TimesPrompted { get; private set; }
 
-        public TestChoicePromptHandler() : base(Logging.CreateLogger().Build())
+        public TestChoicePromptHandler() : base(Logging.NullLogger)
         {
         }
 

test/PowerShellEditorServices.Test/Console/InputPromptHandlerTests.cs

@@ -132,7 +132,7 @@ internal class TestInputPromptHandler : InputPromptHandler
 
         public Exception LastError { get; private set; }
 
-        public TestInputPromptHandler() : base(Logging.CreateLogger().Build())
+        public TestInputPromptHandler() : base(Logging.NullLogger)
         {
         }
 

test/PowerShellEditorServices.Test/Debugging/DebugServiceTests.cs

@@ -31,7 +31,7 @@ public class DebugServiceTests : IDisposable
 
         public DebugServiceTests()
         {
-            var logger = Logging.CreateLogger().Build();
+            var logger = Logging.NullLogger;
 
             this.powerShellContext = PowerShellContextFactory.Create(logger);
             this.powerShellContext.SessionStateChanged += powerShellContext_SessionStateChanged;

test/PowerShellEditorServices.Test/Extensions/ExtensionServiceTests.cs

@@ -36,7 +36,7 @@ private enum EventType
 
         public async Task InitializeAsync()
         {
-            var logger = Logging.CreateLogger().Build();
+            var logger = Logging.NullLogger;
             this.powerShellContext = PowerShellContextFactory.Create(logger);
             await this.powerShellContext.ImportCommandsModule(@"..\..\..\..\..\module\PowerShellEditorServices\Commands");
 

test/PowerShellEditorServices.Test/Language/LanguageServiceTests.cs

@@ -28,7 +28,7 @@ public class LanguageServiceTests : IDisposable
 
         public LanguageServiceTests()
         {
-            var logger = Logging.CreateLogger().Build();
+            var logger = Logging.NullLogger;
             this.powerShellContext = PowerShellContextFactory.Create(logger);
             this.workspace = new Workspace(this.powerShellContext.LocalPowerShellVersion.Version, logger);
             this.languageService = new LanguageService(this.powerShellContext, logger);
@@ -164,7 +164,7 @@ public async Task LanguageServiceFindsFunctionDefinitionInWorkspace()
             var definitionResult =
                 await this.GetDefinition(
                     FindsFunctionDefinitionInWorkspace.SourceDetails,
-                    new Workspace(this.powerShellContext.LocalPowerShellVersion.Version, Logging.CreateLogger().Build())
+                    new Workspace(this.powerShellContext.LocalPowerShellVersion.Version, Logging.NullLogger)
                     {
                         WorkspacePath = Path.Combine(baseSharedScriptPath, @"References")
                     });

test/PowerShellEditorServices.Test/PowerShellContextFactory.cs

@@ -41,7 +41,7 @@ public TestPSHostUserInterface(
             : base(
                 powerShellContext,
                 new SimplePSHostRawUserInterface(logger),
-                Logging.CreateLogger().Build())
+                Logging.NullLogger)
         {
         }
 

test/PowerShellEditorServices.Test/Session/PowerShellContextTests.cs

@@ -42,7 +42,7 @@ public class PowerShellContextTests : IDisposable
 
         public PowerShellContextTests()
         {
-            this.powerShellContext = PowerShellContextFactory.Create(Logging.CreateLogger().Build());
+            this.powerShellContext = PowerShellContextFactory.Create(Logging.NullLogger);
             this.powerShellContext.SessionStateChanged += OnSessionStateChanged;
             this.stateChangeQueue = new AsyncQueue<SessionStateChangedEventArgs>();
         }

test/PowerShellEditorServices.Test/Session/WorkspaceTests.cs

@@ -22,7 +22,7 @@ public void CanResolveWorkspaceRelativePath()
             string testPathOutside = @"c:\Test\PeerPath\FilePath.ps1";
             string testPathAnotherDrive = @"z:\TryAndFindMe\FilePath.ps1";
 
-            Workspace workspace = new Workspace(PowerShellVersion, Logging.CreateLogger().Build());
+            Workspace workspace = new Workspace(PowerShellVersion, Logging.NullLogger);
 
             // Test without a workspace path
             Assert.Equal(testPathOutside, workspace.GetRelativePath(testPathOutside));