Skip to content

Commit 24c147a

Browse files
committed
remove deprecated test code xref pandas-dev#10726
fix some stacklevels on warnings
1 parent 07042a9 commit 24c147a

File tree

10 files changed

+81
-71
lines changed

10 files changed

+81
-71
lines changed

pandas/core/index.py

+9-5
Original file line numberDiff line numberDiff line change
@@ -842,14 +842,14 @@ def to_int():
842842
elif is_float(key):
843843
key = to_int()
844844
warnings.warn("scalar indexers for index type {0} should be integers and not floating point".format(
845-
type(self).__name__),FutureWarning)
845+
type(self).__name__),FutureWarning, stacklevel=8)
846846
return key
847847
return self._invalid_indexer('label', key)
848848

849849
if is_float(key):
850850
if not self.is_floating():
851851
warnings.warn("scalar indexers for index type {0} should be integers and not floating point".format(
852-
type(self).__name__),FutureWarning)
852+
type(self).__name__),FutureWarning, stacklevel=8)
853853
return to_int()
854854

855855
return key
@@ -1488,7 +1488,9 @@ def union(self, other):
14881488
self.values[0] < other_diff[0]
14891489
except TypeError as e:
14901490
warnings.warn("%s, sort order is undefined for "
1491-
"incomparable objects" % e, RuntimeWarning)
1491+
"incomparable objects" % e,
1492+
RuntimeWarning,
1493+
stacklevel=3)
14921494
else:
14931495
types = frozenset((self.inferred_type,
14941496
other.inferred_type))
@@ -1502,7 +1504,9 @@ def union(self, other):
15021504
result = np.sort(result)
15031505
except TypeError as e:
15041506
warnings.warn("%s, sort order is undefined for "
1505-
"incomparable objects" % e, RuntimeWarning)
1507+
"incomparable objects" % e,
1508+
RuntimeWarning,
1509+
stacklevel=3)
15061510

15071511
# for subclasses
15081512
return self._wrap_union_result(other, result)
@@ -5268,7 +5272,7 @@ def _maybe_str_to_time_stamp(key, lev):
52685272
return slice(start, stop)
52695273

52705274
warnings.warn('indexing past lexsort depth may impact performance.',
5271-
PerformanceWarning)
5275+
PerformanceWarning, stacklevel=10)
52725276

52735277
loc = np.arange(start, stop, dtype='int64')
52745278

pandas/tests/test_index.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -971,7 +971,8 @@ def test_add(self):
971971
with tm.assert_produces_warning():
972972
self.strIndex.tolist() + self.strIndex
973973

974-
firstCat = self.strIndex.union(self.dateIndex)
974+
with tm.assert_produces_warning(RuntimeWarning):
975+
firstCat = self.strIndex.union(self.dateIndex)
975976
secondCat = self.strIndex.union(self.strIndex)
976977

977978
if self.dateIndex.dtype == np.object_:
@@ -1635,9 +1636,11 @@ def test_outer_join_sort(self):
16351636

16361637
with tm.assert_produces_warning(RuntimeWarning):
16371638
joined = left_idx.join(right_idx, how='outer')
1639+
16381640
# right_idx in this case because DatetimeIndex has join precedence over
16391641
# Int64Index
1640-
expected = right_idx.astype(object).union(left_idx.astype(object))
1642+
with tm.assert_produces_warning(RuntimeWarning):
1643+
expected = right_idx.astype(object).union(left_idx.astype(object))
16411644
tm.assert_index_equal(joined, expected)
16421645

16431646
def test_nan_first_take_datetime(self):

pandas/tests/test_indexing.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1761,7 +1761,8 @@ def test_ix_general(self):
17611761
key = 4.0, 2012
17621762

17631763
# emits a PerformanceWarning, ok
1764-
tm.assert_frame_equal(df.ix[key], df.iloc[2:])
1764+
with self.assert_produces_warning(PerformanceWarning):
1765+
tm.assert_frame_equal(df.ix[key], df.iloc[2:])
17651766

17661767
# this is ok
17671768
df.sortlevel(inplace=True)

pandas/tools/plotting.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1194,7 +1194,7 @@ def _get_xticks(self, convert_period=False):
11941194

11951195
if self.use_index:
11961196
if convert_period and isinstance(index, PeriodIndex):
1197-
self.data = self.data.reindex(index=index.order())
1197+
self.data = self.data.reindex(index=index.sort_values())
11981198
x = self.data.index.to_timestamp()._mpl_repr()
11991199
elif index.is_numeric():
12001200
"""

pandas/tools/tests/test_merge.py

+11-11
Original file line numberDiff line numberDiff line change
@@ -992,8 +992,8 @@ def test_merge_on_multikey(self):
992992
assert_frame_equal(joined, expected.ix[:, joined.columns])
993993

994994
left = self.data.join(self.to_join, on=['key1', 'key2'], sort=True)
995-
right = expected.ix[:, joined.columns].sort(['key1', 'key2'],
996-
kind='mergesort')
995+
right = expected.ix[:, joined.columns].sort_values(['key1', 'key2'],
996+
kind='mergesort')
997997
assert_frame_equal(left, right)
998998

999999
def test_left_join_multi_index(self):
@@ -1019,7 +1019,7 @@ def run_asserts(left, right):
10191019

10201020
if sort:
10211021
tm.assert_frame_equal(res,
1022-
res.sort(icols, kind='mergesort'))
1022+
res.sort_values(icols, kind='mergesort'))
10231023

10241024
out = merge(left, right.reset_index(), on=icols,
10251025
sort=sort, how='left')
@@ -1099,7 +1099,7 @@ def test_left_join_index_preserve_order(self):
10991099
expected.loc[(expected.k1 == 1) & (expected.k2 == 'foo'),'v2'] = 7
11001100

11011101
tm.assert_frame_equal(result, expected)
1102-
tm.assert_frame_equal(result.sort(['k1', 'k2'], kind='mergesort'),
1102+
tm.assert_frame_equal(result.sort_values(['k1', 'k2'], kind='mergesort'),
11031103
left.join(right, on=['k1', 'k2'], sort=True))
11041104

11051105
# test join with multi dtypes blocks
@@ -1119,7 +1119,7 @@ def test_left_join_index_preserve_order(self):
11191119
expected.loc[(expected.k1 == 1) & (expected.k2 == 'foo'),'v2'] = 7
11201120

11211121
tm.assert_frame_equal(result, expected)
1122-
tm.assert_frame_equal(result.sort(['k1', 'k2'], kind='mergesort'),
1122+
tm.assert_frame_equal(result.sort_values(['k1', 'k2'], kind='mergesort'),
11231123
left.join(right, on=['k1', 'k2'], sort=True))
11241124

11251125
# do a right join for an extra test
@@ -1186,7 +1186,7 @@ def test_left_join_index_multi_match_multiindex(self):
11861186
how='left', sort=True)
11871187

11881188
tm.assert_frame_equal(result,
1189-
expected.sort(['cola', 'colb', 'colc'], kind='mergesort'))
1189+
expected.sort_values(['cola', 'colb', 'colc'], kind='mergesort'))
11901190

11911191
# GH7331 - maintain left frame order in left merge
11921192
right.reset_index(inplace=True)
@@ -1233,7 +1233,7 @@ def test_left_join_index_multi_match(self):
12331233
tm.assert_frame_equal(result, expected)
12341234

12351235
result = left.join(right, on='tag', how='left', sort=True)
1236-
tm.assert_frame_equal(result, expected.sort('tag', kind='mergesort'))
1236+
tm.assert_frame_equal(result, expected.sort_values('tag', kind='mergesort'))
12371237

12381238
# GH7331 - maintain left frame order in left merge
12391239
result = merge(left, right.reset_index(), how='left', on='tag')
@@ -1264,7 +1264,7 @@ def _test(dtype1,dtype2):
12641264
tm.assert_frame_equal(result, expected)
12651265

12661266
result = left.join(right, on=['k1', 'k2'], sort=True)
1267-
expected.sort(['k1', 'k2'], kind='mergesort', inplace=True)
1267+
expected.sort_values(['k1', 'k2'], kind='mergesort', inplace=True)
12681268
tm.assert_frame_equal(result, expected)
12691269

12701270
for d1 in [np.int64,np.int32,np.int16,np.int8,np.uint8]:
@@ -1347,7 +1347,7 @@ def test_int64_overflow_issues(self):
13471347
assert_series_equal(out['left'], result, check_names=False)
13481348
self.assertTrue(result.name is None)
13491349

1350-
out.sort(out.columns.tolist(), inplace=True)
1350+
out.sort_values(out.columns.tolist(), inplace=True)
13511351
out.index = np.arange(len(out))
13521352
for how in ['left', 'right', 'outer', 'inner']:
13531353
assert_frame_equal(out, merge(left, right, how=how, sort=True))
@@ -1411,14 +1411,14 @@ def test_int64_overflow_issues(self):
14111411
vals.append(k + tuple([np.nan, rv]))
14121412

14131413
def align(df):
1414-
df = df.sort(df.columns.tolist())
1414+
df = df.sort_values(df.columns.tolist())
14151415
df.index = np.arange(len(df))
14161416
return df
14171417

14181418
def verify_order(df):
14191419
kcols = list('ABCDEFG')
14201420
assert_frame_equal(df[kcols].copy(),
1421-
df[kcols].sort(kcols, kind='mergesort'))
1421+
df[kcols].sort_values(kcols, kind='mergesort'))
14221422

14231423
out = DataFrame(vals, columns=list('ABCDEFG') + ['left', 'right'])
14241424
out = align(out)

pandas/tseries/tests/test_base.py

+34-34
Original file line numberDiff line numberDiff line change
@@ -305,22 +305,22 @@ def test_order(self):
305305
freq='H', tz='Asia/Tokyo', name='tzidx')
306306

307307
for idx in [idx1, idx2]:
308-
ordered = idx.order()
308+
ordered = idx.sort_values()
309309
self.assert_index_equal(ordered, idx)
310310
self.assertEqual(ordered.freq, idx.freq)
311311

312-
ordered = idx.order(ascending=False)
312+
ordered = idx.sort_values(ascending=False)
313313
expected = idx[::-1]
314314
self.assert_index_equal(ordered, expected)
315315
self.assertEqual(ordered.freq, expected.freq)
316316
self.assertEqual(ordered.freq.n, -1)
317317

318-
ordered, indexer = idx.order(return_indexer=True)
318+
ordered, indexer = idx.sort_values(return_indexer=True)
319319
self.assert_index_equal(ordered, idx)
320320
self.assert_numpy_array_equal(indexer, np.array([0, 1, 2]))
321321
self.assertEqual(ordered.freq, idx.freq)
322322

323-
ordered, indexer = idx.order(return_indexer=True, ascending=False)
323+
ordered, indexer = idx.sort_values(return_indexer=True, ascending=False)
324324
expected = idx[::-1]
325325
self.assert_index_equal(ordered, expected)
326326
self.assert_numpy_array_equal(indexer, np.array([2, 1, 0]))
@@ -346,20 +346,20 @@ def test_order(self):
346346
'2011-01-05'], name='idx3')
347347

348348
for idx, expected in [(idx1, exp1), (idx1, exp1), (idx1, exp1)]:
349-
ordered = idx.order()
349+
ordered = idx.sort_values()
350350
self.assert_index_equal(ordered, expected)
351351
self.assertIsNone(ordered.freq)
352352

353-
ordered = idx.order(ascending=False)
353+
ordered = idx.sort_values(ascending=False)
354354
self.assert_index_equal(ordered, expected[::-1])
355355
self.assertIsNone(ordered.freq)
356356

357-
ordered, indexer = idx.order(return_indexer=True)
357+
ordered, indexer = idx.sort_values(return_indexer=True)
358358
self.assert_index_equal(ordered, expected)
359359
self.assert_numpy_array_equal(indexer, np.array([0, 4, 3, 1, 2]))
360360
self.assertIsNone(ordered.freq)
361361

362-
ordered, indexer = idx.order(return_indexer=True, ascending=False)
362+
ordered, indexer = idx.sort_values(return_indexer=True, ascending=False)
363363
self.assert_index_equal(ordered, expected[::-1])
364364
self.assert_numpy_array_equal(indexer, np.array([2, 1, 3, 4, 0]))
365365
self.assertIsNone(ordered.freq)
@@ -900,22 +900,22 @@ def test_order(self):
900900
idx2 = TimedeltaIndex(['1 hour', '2 hour', '3 hour'], freq='H', name='idx')
901901

902902
for idx in [idx1, idx2]:
903-
ordered = idx.order()
903+
ordered = idx.sort_values()
904904
self.assert_index_equal(ordered, idx)
905905
self.assertEqual(ordered.freq, idx.freq)
906906

907-
ordered = idx.order(ascending=False)
907+
ordered = idx.sort_values(ascending=False)
908908
expected = idx[::-1]
909909
self.assert_index_equal(ordered, expected)
910910
self.assertEqual(ordered.freq, expected.freq)
911911
self.assertEqual(ordered.freq.n, -1)
912912

913-
ordered, indexer = idx.order(return_indexer=True)
913+
ordered, indexer = idx.sort_values(return_indexer=True)
914914
self.assert_index_equal(ordered, idx)
915915
self.assert_numpy_array_equal(indexer, np.array([0, 1, 2]))
916916
self.assertEqual(ordered.freq, idx.freq)
917917

918-
ordered, indexer = idx.order(return_indexer=True, ascending=False)
918+
ordered, indexer = idx.sort_values(return_indexer=True, ascending=False)
919919
self.assert_index_equal(ordered, idx[::-1])
920920
self.assertEqual(ordered.freq, expected.freq)
921921
self.assertEqual(ordered.freq.n, -1)
@@ -936,20 +936,20 @@ def test_order(self):
936936
'5 minute'], name='idx3')
937937

938938
for idx, expected in [(idx1, exp1), (idx1, exp1), (idx1, exp1)]:
939-
ordered = idx.order()
939+
ordered = idx.sort_values()
940940
self.assert_index_equal(ordered, expected)
941941
self.assertIsNone(ordered.freq)
942942

943-
ordered = idx.order(ascending=False)
943+
ordered = idx.sort_values(ascending=False)
944944
self.assert_index_equal(ordered, expected[::-1])
945945
self.assertIsNone(ordered.freq)
946946

947-
ordered, indexer = idx.order(return_indexer=True)
947+
ordered, indexer = idx.sort_values(return_indexer=True)
948948
self.assert_index_equal(ordered, expected)
949949
self.assert_numpy_array_equal(indexer, np.array([0, 4, 3, 1, 2]))
950950
self.assertIsNone(ordered.freq)
951951

952-
ordered, indexer = idx.order(return_indexer=True, ascending=False)
952+
ordered, indexer = idx.sort_values(return_indexer=True, ascending=False)
953953
self.assert_index_equal(ordered, expected[::-1])
954954
self.assert_numpy_array_equal(indexer, np.array([2, 1, 3, 4, 0]))
955955
self.assertIsNone(ordered.freq)
@@ -1480,20 +1480,20 @@ def _check_freq(index, expected_index):
14801480
# for compatibility check
14811481
iidx = Index([2011, 2012, 2013], name='idx')
14821482
for idx in [pidx, iidx]:
1483-
ordered = idx.order()
1483+
ordered = idx.sort_values()
14841484
self.assert_index_equal(ordered, idx)
14851485
_check_freq(ordered, idx)
14861486

1487-
ordered = idx.order(ascending=False)
1487+
ordered = idx.sort_values(ascending=False)
14881488
self.assert_index_equal(ordered, idx[::-1])
14891489
_check_freq(ordered, idx[::-1])
14901490

1491-
ordered, indexer = idx.order(return_indexer=True)
1491+
ordered, indexer = idx.sort_values(return_indexer=True)
14921492
self.assert_index_equal(ordered, idx)
14931493
self.assert_numpy_array_equal(indexer, np.array([0, 1, 2]))
14941494
_check_freq(ordered, idx)
14951495

1496-
ordered, indexer = idx.order(return_indexer=True, ascending=False)
1496+
ordered, indexer = idx.sort_values(return_indexer=True, ascending=False)
14971497
self.assert_index_equal(ordered, idx[::-1])
14981498
self.assert_numpy_array_equal(indexer, np.array([2, 1, 0]))
14991499
_check_freq(ordered, idx[::-1])
@@ -1504,32 +1504,32 @@ def _check_freq(index, expected_index):
15041504
iidx = Index([2011, 2013, 2015, 2012, 2011], name='idx')
15051505
iexpected = Index([2011, 2011, 2012, 2013, 2015], name='idx')
15061506
for idx, expected in [(pidx, pexpected), (iidx, iexpected)]:
1507-
ordered = idx.order()
1507+
ordered = idx.sort_values()
15081508
self.assert_index_equal(ordered, expected)
15091509
_check_freq(ordered, idx)
15101510

1511-
ordered = idx.order(ascending=False)
1511+
ordered = idx.sort_values(ascending=False)
15121512
self.assert_index_equal(ordered, expected[::-1])
15131513
_check_freq(ordered, idx)
15141514

1515-
ordered, indexer = idx.order(return_indexer=True)
1515+
ordered, indexer = idx.sort_values(return_indexer=True)
15161516
self.assert_index_equal(ordered, expected)
15171517
self.assert_numpy_array_equal(indexer, np.array([0, 4, 3, 1, 2]))
15181518
_check_freq(ordered, idx)
15191519

1520-
ordered, indexer = idx.order(return_indexer=True, ascending=False)
1520+
ordered, indexer = idx.sort_values(return_indexer=True, ascending=False)
15211521
self.assert_index_equal(ordered, expected[::-1])
15221522
self.assert_numpy_array_equal(indexer, np.array([2, 1, 3, 4, 0]))
15231523
_check_freq(ordered, idx)
15241524

15251525
pidx = PeriodIndex(['2011', '2013', 'NaT', '2011'], name='pidx', freq='D')
15261526

1527-
result = pidx.order()
1527+
result = pidx.sort_values()
15281528
expected = PeriodIndex(['NaT', '2011', '2011', '2013'], name='pidx', freq='D')
15291529
self.assert_index_equal(result, expected)
15301530
self.assertEqual(result.freq, 'D')
15311531

1532-
result = pidx.order(ascending=False)
1532+
result = pidx.sort_values(ascending=False)
15331533
expected = PeriodIndex(['2013', '2011', '2011', 'NaT'], name='pidx', freq='D')
15341534
self.assert_index_equal(result, expected)
15351535
self.assertEqual(result.freq, 'D')
@@ -1539,21 +1539,21 @@ def test_order(self):
15391539
freq='D', name='idx')
15401540

15411541
for idx in [idx1]:
1542-
ordered = idx.order()
1542+
ordered = idx.sort_values()
15431543
self.assert_index_equal(ordered, idx)
15441544
self.assertEqual(ordered.freq, idx.freq)
15451545

1546-
ordered = idx.order(ascending=False)
1546+
ordered = idx.sort_values(ascending=False)
15471547
expected = idx[::-1]
15481548
self.assert_index_equal(ordered, expected)
15491549
self.assertEqual(ordered.freq, 'D')
15501550

1551-
ordered, indexer = idx.order(return_indexer=True)
1551+
ordered, indexer = idx.sort_values(return_indexer=True)
15521552
self.assert_index_equal(ordered, idx)
15531553
self.assert_numpy_array_equal(indexer, np.array([0, 1, 2]))
15541554
self.assertEqual(ordered.freq, 'D')
15551555

1556-
ordered, indexer = idx.order(return_indexer=True, ascending=False)
1556+
ordered, indexer = idx.sort_values(return_indexer=True, ascending=False)
15571557
expected = idx[::-1]
15581558
self.assert_index_equal(ordered, expected)
15591559
self.assert_numpy_array_equal(indexer, np.array([2, 1, 0]))
@@ -1577,20 +1577,20 @@ def test_order(self):
15771577
'2011-01-05'], freq='D', name='idx3')
15781578

15791579
for idx, expected in [(idx1, exp1), (idx1, exp1), (idx1, exp1)]:
1580-
ordered = idx.order()
1580+
ordered = idx.sort_values()
15811581
self.assert_index_equal(ordered, expected)
15821582
self.assertEqual(ordered.freq, 'D')
15831583

1584-
ordered = idx.order(ascending=False)
1584+
ordered = idx.sort_values(ascending=False)
15851585
self.assert_index_equal(ordered, expected[::-1])
15861586
self.assertEqual(ordered.freq, 'D')
15871587

1588-
ordered, indexer = idx.order(return_indexer=True)
1588+
ordered, indexer = idx.sort_values(return_indexer=True)
15891589
self.assert_index_equal(ordered, expected)
15901590
self.assert_numpy_array_equal(indexer, np.array([0, 4, 3, 1, 2]))
15911591
self.assertEqual(ordered.freq, 'D')
15921592

1593-
ordered, indexer = idx.order(return_indexer=True, ascending=False)
1593+
ordered, indexer = idx.sort_values(return_indexer=True, ascending=False)
15941594
self.assert_index_equal(ordered, expected[::-1])
15951595
self.assert_numpy_array_equal(indexer, np.array([2, 1, 3, 4, 0]))
15961596
self.assertEqual(ordered.freq, 'D')

0 commit comments

Comments
 (0)