Skip to content

Commit dbffa5e

Browse files
simonjayhawkinsrhshadrach
authored andcommitted
TST: pd.NA TypeError in drop_duplicates with object dtype (pandas-dev#33751)
1 parent 35ce938 commit dbffa5e

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

pandas/conftest.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,9 @@ def nselect_method(request):
256256
# ----------------------------------------------------------------
257257
# Missing values & co.
258258
# ----------------------------------------------------------------
259-
@pytest.fixture(params=[None, np.nan, pd.NaT, float("nan"), np.float("NaN"), pd.NA])
259+
@pytest.fixture(
260+
params=[None, np.nan, pd.NaT, float("nan"), np.float("NaN"), pd.NA], ids=str
261+
)
260262
def nulls_fixture(request):
261263
"""
262264
Fixture for each null type in pandas.

pandas/tests/frame/methods/test_drop_duplicates.py

+7
Original file line numberDiff line numberDiff line change
@@ -418,3 +418,10 @@ def test_drop_duplicates_ignore_index(
418418

419419
tm.assert_frame_equal(result_df, expected)
420420
tm.assert_frame_equal(df, DataFrame(origin_dict))
421+
422+
423+
def test_drop_duplicates_null_in_object_column(nulls_fixture):
424+
# https://github.com/pandas-dev/pandas/issues/32992
425+
df = DataFrame([[1, nulls_fixture], [2, "a"]], dtype=object)
426+
result = df.drop_duplicates()
427+
tm.assert_frame_equal(result, df)

0 commit comments

Comments
 (0)