Skip to content

Commit 7b5998a

Browse files
committed
Merge pull request scala#4271 from retronym/ticket/8642
SI-8642 Enable OSGi tests under Java 8
2 parents 20cb778 + 80d56a4 commit 7b5998a

File tree

3 files changed

+28
-3
lines changed

3 files changed

+28
-3
lines changed

build.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ TODO:
280280

281281
<!-- Pax runner -->
282282
<property name="pax.exam.version" value="3.5.0"/><!-- Last version which supports Java 6 -->
283-
<property name="osgi.felix.version" value="4.0.3"/>
283+
<property name="osgi.felix.version" value="4.4.0"/>
284284
<property name="osgi.equinox.version" value="3.7.1"/>
285285
<artifact:dependencies pathId="pax.exam.classpath" filesetId="pax.exam.fileset">
286286
<dependency groupId="org.ops4j.pax.exam" artifactId="pax-exam-container-native" version="${pax.exam.version}">
@@ -294,6 +294,7 @@ TODO:
294294
<dependency groupId="ch.qos.logback" artifactId="logback-classic" version="1.1.2"/>
295295
<dependency groupId="junit" artifactId="junit" version="${junit.version}"/>
296296
</artifact:dependencies>
297+
<copy-deps project="pax.exam"/>
297298

298299
<artifact:dependencies pathId="osgi.framework.felix">
299300
<dependency groupId="org.apache.felix" artifactId="org.apache.felix.framework" version="${osgi.felix.version}"/>
@@ -1375,8 +1376,8 @@ TODO:
13751376
</target>
13761377

13771378
<target name="test.osgi" depends="test.osgi.comp">
1378-
<if><isset property="has.java8"/><then>
1379-
<echo message="Skipping OSGi JUnit tests on Java 8. See SI-8642"/>
1379+
<if><isset property="test.osgi.skip"/><then>
1380+
<echo message="Skipping OSGi JUnit tests"/>
13801381
</then><else>
13811382
<echo message="Running OSGi JUnit tests. Output in ${build-osgi.dir}"/>
13821383
<stopwatch name="test.osgi.timer"/>

src/intellij/scala-lang.ipr.SAMPLE

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,7 @@
218218
<module fileurl="file://$PROJECT_DIR$/scalap.iml" filepath="$PROJECT_DIR$/scalap.iml" />
219219
<module fileurl="file://$PROJECT_DIR$/test.iml" filepath="$PROJECT_DIR$/test.iml" />
220220
<module fileurl="file://$PROJECT_DIR$/test-junit.iml" filepath="$PROJECT_DIR$/test-junit.iml" />
221+
<module fileurl="file://$PROJECT_DIR$/test-osgi.iml" filepath="$PROJECT_DIR$/test-osgi.iml" />
221222
</modules>
222223
</component>
223224
<component name="ProjectResources">

src/intellij/test-osgi.iml.SAMPLE

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<module type="JAVA_MODULE" version="4">
3+
<component name="NewModuleRootManager" inherit-compiler-output="true">
4+
<exclude-output />
5+
<content url="file://$MODULE_DIR$/../../test/osgi">
6+
<sourceFolder url="file://$MODULE_DIR$/../../test/osgi/src" isTestSource="false" />
7+
</content>
8+
<orderEntry type="inheritedJdk" />
9+
<orderEntry type="sourceFolder" forTests="false" />
10+
<orderEntry type="module" module-name="actors" />
11+
<orderEntry type="module" module-name="asm" />
12+
<orderEntry type="module" module-name="compiler" />
13+
<orderEntry type="module" module-name="library" />
14+
<orderEntry type="module" module-name="reflect" />
15+
<orderEntry type="module" module-name="repl" />
16+
<orderEntry type="module" module-name="partest-extras" />
17+
<orderEntry type="module" module-name="forkjoin" />
18+
<orderEntry type="library" name="junit" level="project" />
19+
<orderEntry type="library" name="scaladoc-deps" level="project" />
20+
<orderEntry type="library" name="scala-sdk" level="project" />
21+
<orderEntry type="library" scope="PROVIDED" name="pax.exam-deps" level="project" />
22+
</component>
23+
</module>

0 commit comments

Comments
 (0)