Simplify decision about whether to emit ACC_ABSTRACT

retronym · retronym · commit 60ac55a7ea13 · 2015-12-09T15:58:01.000+10:00
Look at the RHS of the DefDef, rather than at flags of the Symbol
diff --git a/src/compiler/scala/tools/nsc/backend/jvm/BCodeSkelBuilder.scala b/src/compiler/scala/tools/nsc/backend/jvm/BCodeSkelBuilder.scala
@@ -568,7 +568,7 @@ abstract class BCodeSkelBuilder extends BCodeHelpers {
       }
 
       val isNative         = methSymbol.hasAnnotation(definitions.NativeAttr)
-      val isAbstractMethod = (methSymbol.isDeferred || methSymbol.owner.isInterface) && !methSymbol.hasFlag(Flags.JAVA_DEFAULTMETHOD)
+      val isAbstractMethod = rhs == EmptyTree
       val flags = GenBCode.mkFlags(
         javaFlags(methSymbol),
         if (isAbstractMethod)        asm.Opcodes.ACC_ABSTRACT   else 0,

Original file line number	Diff line number	Diff line change
`@@ -568,7 +568,7 @@ abstract class BCodeSkelBuilder extends BCodeHelpers {`
`568`	`568`	`}`
`569`	`569`
`570`	`570`	`val isNative = methSymbol.hasAnnotation(definitions.NativeAttr)`
`571`		`- val isAbstractMethod = (methSymbol.isDeferred \|\| methSymbol.owner.isInterface) && !methSymbol.hasFlag(Flags.JAVA_DEFAULTMETHOD)`
	`571`	`+ val isAbstractMethod = rhs == EmptyTree`
`572`	`572`	`val flags = GenBCode.mkFlags(`
`573`	`573`	`javaFlags(methSymbol),`
`574`	`574`	`if (isAbstractMethod) asm.Opcodes.ACC_ABSTRACT else 0,`