Skip to content

Bun integration test is flakey, possibly due to bug in stream implementation #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattt opened this issue Mar 19, 2024 · 3 comments
Closed

Comments

@mattt
Copy link
Contributor

mattt commented Mar 19, 2024

The integration test for Bun fails sporadically with a timeout. Re-running usually results in a successful run.

For example, here's a run that failed: https://github.com/replicate/replicate-javascript/actions/runs/8340326500/job/22824063223

And here's the retry, which succeeded: https://github.com/replicate/replicate-javascript/actions/runs/8340326500/job/22824613649

What's concerning is that both predictions succeeded:

This makes me think that the flakiness is actually a problem in our streaming code. And if we aren't seeing this with the other integration tests, then that suggests a problem in our TextDecoderStream polyfill.

@mattt
Copy link
Contributor Author

mattt commented Mar 19, 2024

@aron Any ideas why we're seeing this?

@aron
Copy link
Contributor

aron commented May 2, 2024

Not sure. There's not much to that TextDecoderStream polyfill we added. Could it also be something to do with the Bun fetch/Response implementation…? We'd have to add more profiling/debugging information to the bun test I think to understand where in the code it's timing out.

@mattt
Copy link
Contributor Author

mattt commented Jul 5, 2024

I haven't observed this test flakiness recently — in fact, working on #281, I noticed that Bun was the only integration test that didn't occasionally fail with a 503 error. Switching everything to replicate/canary in #283 should stop this from happening in the future.

@mattt mattt closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants