Merge branch 'clippy' into 'master'

Fix some clippy warnings

See merge request redox-os/uefi!11

Author: jackpot51

crates/uefi_std/src/exec.rs

@@ -17,7 +17,7 @@ pub fn exec_data(data: &[u8], name: &str, args: &[&str]) -> Result<usize> {
     for arg in args.iter() {
         cmdline.push_str(" \"");
         cmdline.push_str(arg);
-        cmdline.push_str("\"");
+        cmdline.push('"');
     }
     cmdline.push('\0');
 

crates/uefi_std/src/fs.rs

@@ -1,4 +1,4 @@
-use core::{mem, slice};
+use core::{mem, ptr, slice};
 use uefi::fs::{File as InnerFile, FileInfo, SimpleFileSystem, FILE_MODE_READ};
 use uefi::guid::{Guid, FILE_INFO_ID, FILE_SYSTEM_GUID};
 use uefi::status::{Error, Result};
@@ -20,7 +20,7 @@ impl Protocol<SimpleFileSystem> for FileSystem {
 
 impl FileSystem {
     pub fn root(&mut self) -> Result<Dir> {
-        let mut interface = 0 as *mut InnerFile;
+        let mut interface = ptr::null_mut::<InnerFile>();
         (self.0.OpenVolume)(self.0, &mut interface)?;
 
         Ok(Dir(File(unsafe { &mut *interface })))
@@ -84,7 +84,7 @@ pub struct Dir(pub File);
 
 impl Dir {
     pub fn open(&mut self, filename: &[u16]) -> Result<File> {
-        let mut interface = 0 as *mut InnerFile;
+        let mut interface = ptr::null_mut::<InnerFile>();
         ((self.0).0.Open)((self.0).0, &mut interface, filename.as_ptr(), FILE_MODE_READ, 0)?;
 
         Ok(File(unsafe { &mut *interface }))

crates/uefi_std/src/proto.rs

@@ -48,6 +48,6 @@ pub trait Protocol<T: 'static> {
     }
 
     fn all() -> Vec<Self> where Self: Sized {
-        Self::locate_handle().unwrap_or(Vec::new())
+        Self::locate_handle().unwrap_or_default()
     }
 }

crates/uefi_std/src/vars.rs

@@ -85,7 +85,7 @@ pub fn get_boot_item(num: u16) -> Result<Vec<u8>> {
 }
 
 pub fn set_boot_item(num: u16, data: &[u8]) -> Result<usize> {
-    set(&format!("Boot{:>04X}", num), &data)
+    set(&format!("Boot{:>04X}", num), data)
 }
 
 pub fn get_os_indications() -> Result<u64> {