Fix https:// notifications if TLSvX is mandatory #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowadays servers tend to use TLSv1.[12] and SSLv3 will start to disappear as only ie6 requires it… In the post-receive hook SSLv3 is forced and notification fails if server only accepts TLSv1.[12] (eg: server gets 'A+' on https://www.ssllabs.com/ssltest/) ``` remote: Notifying Redmine about changes to this repository : 'project/repo' ... remote: Redmine URL : 'https://myforge/githooks/post-receive/redmine/project' remote: HTTP_ERROR : SSL_connect returned=1 errno=0 state=SSLv3 read server hello A: sslv3 alert handshake failure remote: Error contacting Redmine about changes to this repo. ```
| @@ -83,7 +83,6 @@ def run_http_query(git_config) | |||
|
|
|||
| if url.scheme == 'https' | |||
| http.use_ssl = true | |||
| http.ssl_version = :SSLv3 if http.respond_to?(:ssl_version) | |||
There was a problem hiding this comment.
default seems to negociate SSL/TLS protocol
|
Hi! Thanks for your feedback! I don't know if I can merge this patch now as it conflicts with #53. |
|
I dont think sslv2 is still default... |
n-rodriguez
pushed a commit
that referenced
this pull request
Jun 21, 2014
Fix https:// notifications if TLSvX is mandatory
|
thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays servers tend to use TLSv1.[12] and SSLv3 will start to disappear
as only ie6 requires it…
In the post-receive hook SSLv3 is forced and notification fails
if server only accepts TLSv1.[12](eg: server gets 'A+' on https://www.ssllabs.com/ssltest/)
This change let ruby's ssl stack negociate protocol with the server (works for me™ with a TLS-only server)