[Feature Request] Code review

[gituser]

Hi.

Been using this plugin for quite some time and was happy with it.

But now I need to review the code before push it to the specific branch and sync production with it.

Is there any decent method to organize such code review with this plugin?

or should i install this - http://www.r-labs.org/projects/r-labs/wiki/Code_Review_en ?

Many thanks.

from what I've read on the latter subject its not really user-friendly.

[n-rodriguez]

or should i install this - http://www.r-labs.org/projects/r-labs/wiki/Code_Review_en ?

Install it, look nice ;)
I'm gonna test it!

[gituser]

thanks for your answer.

from what I've read it seems to be just a system for commenting on particular diff/commit rather than actual allowing/deny system (like gerrit or reviewboard or crucible which not allow to push to specific branch before reviewer accept the commit).

i might try it later too, but let me know if you do it before me :)

Ideally I'd love something which will give me visual ability to review code and few buttons to accept/reject or alter the code in the diff before commit and notify the guy who pushed the diff.

I just thought someone already implemented this for redmine.

[n-rodriguez]

Unfortunately not. What you ask for is pull request. I'd love to implement it in Redmine, but this could take some time unless someone else do it (contributors, where are you?) because I will have less time to spend on the plugin soon.

[gituser]

@n-rodriguez yes this is exactly what i need.

this might be resolvable as well with a git hook i think, maybe auto-create an issue for each commit and notify via e-mail and do not push unless issue is closed.

i'm not good at ruby, so i guess i need to wait for someone to implement this :/

[n-rodriguez]

this might be resolvable as well with a git hook i think, maybe auto-create an issue for each commit and notify via e-mail and do not push unless issue is closed.

This could work but it's a little tricky.
And it won't prevent people from pushing unless you add some code in Redmine that will check for each commit if there is an opened issue.
Also, note that this could only work with SmartHTTP as SSH access bypasses Redmine.

[gituser]

Also, note that this could only work with SmartHTTP as SSH access bypasses Redmine.

well yes, but what do you think about git-precommit hook?

[n-rodriguez]

The same. I think this must be done on server side. Take a look at Gitlab and how they implement Pull Requests.

[gituser]

i'm currently checking out http://phabricator.org/

maybe it would help someone :)

[n-rodriguez]

Thanks!
I'm gonna take a look, looks nice, but I don't think it will replace Redmine ;)

[gituser]

sure, i think im gonna use it just for a code review.

[gituser]

hi.

phabricator is not really an option.

ideally would be nice to have this functionality in your plug-in (redmine_git_hosting), also it's very logical to have this feature since it's related to git.
maybe implement this feature as a separate plug-in or feature which can be turned on if needed?
take a look at Atlassian Stash: https://www.atlassian.com/software/stash this might be the thing needed but for redmine.

all redmine code review plugins are ugly, very complicated. using gerrit also is very complicated.

i can fund you a bit in your development just send me your bitcoin address.

[n-rodriguez]

ideally would be nice to have this functionality in your plug-in (redmine_git_hosting), also it's very logical to have this feature since it's related to git.

I agree with you

i can fund you a bit in your development just send me your bitcoin address.

That's nice but I think this kind of feature should be funded by a whole community (crowd funding ?). This is not easy to do and could possibly take a lot ot time. You're the second person I know who's asking for code reviews in Redmine. That's a beginning but no enough to spend a lot of time on it.
Maybe you could raise some funds with a Kick starter operation?

[bes1002t]

I'm very interested in this feature too!
this would mean a huge improvement of redmine and your plugin. Start a Kickstarter campaign or something, I will donate.

[pva]

We are interested in this feature as well and in case of campaign we'll donate. Do we have any platform for such donations? I found www.bountysource.com but from the first page there are too many bugs, so I'm undecided about using it.

[bellatriks]

I'll donate too :) Especially for the Pull request feature!