Plugin fails to determine git version

[CMoH]

Here is a shell conversation that I believe explains what's wrong:

redmine@dev ~ $ tail -n1 log/git_hosting.log 
2018-07-03 23:23:47 +0300 [ERROR] Can't retrieve Git version: Non-zero exit code pid 29467 exit 129 for `sudo -n -u git -i git --version --no-color`
redmine@dev ~ $ sudo -n -u git -i git --version --no-color
error: unknown option `no-color'
usage: git version [<options>]

    --build-options       also print build options

redmine@dev ~ $ sudo -n -u git -i git --version      
git version 2.16.4

[CMoH]

Is this due to the same problem?

It would not bother me that much, except when I try to create a new repository I'm getting this thing, and the Create button is disable:

What can I do?

[munzeitig]

Hello,
similar problem was discussed with the Redmine native "git".
It is related to upgrading your git version, where newer version do not support the --no-color parameter.
See sameersbn/docker-redmine#305

So I beleive you need to analogically edit the plugin files:
plugins/redmine_git_hosting/lib/redmine_git_hosting/commands/git.rb (line 86)and
plugins/redmine_git_hosting/lib/redmine/scm/adapters/xitolite_adapter.rb
(lines 84, 181, 211, 334, 336, 389, 408)
and remove the "--no-color" parameter from there.

[munzeitig]

Just to confirm, I have edited the 2 files mentioned above, removed all the "--no-color" params and it works fine now.

[CMoH]

Thank you. I applied your changes and now the plugin works. Maybe I can turn this into a PR which works on both git versions.

[pva]

While it is correct to remove --no-color in git --version, it is bad idea to remove --no-color in xitolite_adapter.rb since log/diff/branch commands have this argument. So the only change that is needed is in ./lib/redmine_git_hosting/commands/git.rb.

[PowerKiKi]

As discussed in #732 (comment), issues related to Redmine < 4.0 or severely outdated issues are being closed to help clean up the issue tracker.

If this issue is still relevant to you and you are running Redmine >= 4.0, please open a new issue including all new relevant information.