Skip to content

[devel] Incorrect protected branch gitolite refex #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
netsuo opened this issue Nov 10, 2015 · 2 comments
Closed

[devel] Incorrect protected branch gitolite refex #534

netsuo opened this issue Nov 10, 2015 · 2 comments
Assignees
Labels

Comments

@netsuo
Copy link

netsuo commented Nov 10, 2015

Without any protected branch setup, the refex is correctly generated with every "developer_team" users that have the "commit" role set:

repo    project
  RW+                   = user1, user2, user3

When you add a protected branch, there is only one line remaining for the users that you added on the protected branch:

repo    project
  RW+   master          = user1

This is not correct, because now you only have one protected branch and every other team member cannot do anything in any branch.
The generated config should include 2 lines for each protected branch, one "RW+/RW/whathever" for the user you added and one "-" for every other users on the team. It should also add the main refex without any specified branch, like if you hadn't setup a protected branch:

repo    project
  RW+   master          = user1
  -     master          = user2, user3
  RW+                   = user1, user2, user3

At best, the generated config file should generate the "normal" refex that you would obtain without setting any protected branch + add theses 2 lines for every protected branch.

I don't know if it's what you tried to achieve but with this, you can set a group in Redmine that can commit on every branch by default, and with adding protected branch, you can allow only certain user to push/delete/whatever to theses branches, while retaining full Redmine user role management.

@n-rodriguez
Copy link
Contributor

The generated config should include 2 lines for each protected branch, one "RW+/RW/whathever" for the user you added and one "-" for every other users on the team

This part is up to you. I can't guess which users should be able to commit or not on a specific branch.

@n-rodriguez n-rodriguez self-assigned this Nov 17, 2015
@n-rodriguez
Copy link
Contributor

Can you please test with the latest release? (1.2.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants