Rubocop offences manual fixes

Author: PowerKiKi

Diff for: app/controllers/concerns/xitolite_repository_finder.rb

@@ -16,12 +16,12 @@ def find_xitolite_repository_by_path
     repo_path = "#{params[:repo_path]}.git"
     repository = Repository::Xitolite.find_by_path repo_path, loose: true
     if repository.nil?
-      RedmineGitHosting.logger.error "GoRedirector : repository not found at path : '#{repo_path}'," \
-                                     ' exiting!'
+      RedmineGitHosting.logger.error "GoRedirector : repository not found at path : '#{repo_path}', " \
+                                     'exiting!'
       render_404
     elsif !repository.go_access_available?
-      RedmineGitHosting.logger.error "GoRedirector : GoAccess is disabled for this repository '#{repository.gitolite_repository_name}'," \
-                                     ' exiting!'
+      RedmineGitHosting.logger.error "GoRedirector : GoAccess is disabled for this repository '#{repository.gitolite_repository_name}', " \
+                                     'exiting!'
       render_403
     else
       RedmineGitHosting.logger.info "GoRedirector : access granted for repository '#{repository.gitolite_repository_name}'"

Diff for: lib/redmine/scm/adapters/xitolite_adapter.rb

@@ -187,7 +187,7 @@ def lastrev(path, rev)
           nil
         end
 
-        def revisions(path, identifier_from, identifier_to, options = {})
+        def revisions(path, identifier_from, identifier_to, options = {}) # rubocop:disable Style/OptionHash
           revs = Revisions.new
           cmd_args = %w[log --no-color --encoding=UTF-8 --raw --date=iso --pretty=fuller --parents --stdin]
           cmd_args << '--no-renames' if self.class.client_version_above? [2, 9]

Diff for: lib/redmine_git_hosting/gitolite_handlers/repositories/move_repository.rb

@@ -110,8 +110,8 @@ def move_physical_repo(old_path, new_path, new_parent_path)
 
           ## CASE 3
           elsif !new_path_exists && !old_path_exists
-            logger.error "#{context} : both old repository '#{old_path}' and new repository '#{new_path}' does not exist, cannot move it," \
-                         ' exit but let Gitolite create the new repo !'
+            logger.error "#{context} : both old repository '#{old_path}' and new repository '#{new_path}' does not exist, " \
+                         'cannot move it, exit but let Gitolite create the new repo !'
             true
 
           ## CASE 4
@@ -126,8 +126,8 @@ def move_physical_repo_case_1(old_path, new_path)
             logger.warn "#{context} : target repository '#{new_path}' already exists and is empty, remove it ..."
             delete_directory! new_path, :target
           else
-            logger.warn "#{context} : target repository '#{new_path}' exists and is not empty, considered as already moved, try to remove" \
-                        ' the old_path if empty'
+            logger.warn "#{context} : target repository '#{new_path}' exists and is not empty, " \
+                        'considered as already moved, try to remove the old_path if empty'
             if empty_repository? old_path
               delete_directory! old_path, :source
             else

Diff for: lib/tasks/migration_tools.rake

@@ -13,26 +13,26 @@ namespace :redmine_git_hosting do
         puts "new_name : #{new_name}"
 
         # Get the old migration name
-        query  = "SELECT * FROM #{ActiveRecord::Base.connection.quote_string 'schema_migrations'}" \
-                 " WHERE #{ActiveRecord::Base.connection.quote_string 'version'} =" \
-                 " '#{ActiveRecord::Base.connection.quote_string old_name}';"
+        query  = "SELECT * FROM #{ActiveRecord::Base.connection.quote_string 'schema_migrations'} " \
+                 "WHERE #{ActiveRecord::Base.connection.quote_string 'version'} = " \
+                 "'#{ActiveRecord::Base.connection.quote_string old_name}';"
         result = ActiveRecord::Base.connection.execute query
 
         # If present, rename
         if result.to_a.present?
-          query = "DELETE FROM #{ActiveRecord::Base.connection.quote_string 'schema_migrations'}" \
-                  " WHERE #{ActiveRecord::Base.connection.quote_string 'version'} =" \
-                  " '#{ActiveRecord::Base.connection.quote_string old_name}';"
+          query = "DELETE FROM #{ActiveRecord::Base.connection.quote_string 'schema_migrations'} " \
+                  "WHERE #{ActiveRecord::Base.connection.quote_string 'version'} = " \
+                  "'#{ActiveRecord::Base.connection.quote_string old_name}';"
           ActiveRecord::Base.connection.execute query
 
-          query = "INSERT INTO #{ActiveRecord::Base.connection.quote_string 'schema_migrations'} (VERSION)" \
-                  " VALUES ('#{ActiveRecord::Base.connection.quote_string new_name}');"
+          query = "INSERT INTO #{ActiveRecord::Base.connection.quote_string 'schema_migrations'} (VERSION) " \
+                  "VALUES ('#{ActiveRecord::Base.connection.quote_string new_name}');"
           ActiveRecord::Base.connection.execute query
         else
           # Check the new name is present
-          query  = "SELECT * FROM #{ActiveRecord::Base.connection.quote_string 'schema_migrations'}" \
-                   " WHERE #{ActiveRecord::Base.connection.quote_string 'version'} =" \
-                   " '#{ActiveRecord::Base.connection.quote_string new_name}';"
+          query  = "SELECT * FROM #{ActiveRecord::Base.connection.quote_string 'schema_migrations'} " \
+                   "WHERE #{ActiveRecord::Base.connection.quote_string 'version'} = " \
+                   "'#{ActiveRecord::Base.connection.quote_string new_name}';"
           result = ActiveRecord::Base.connection.execute query
 
           if result.to_a.empty?

Diff for: spec/models/gitolite_public_key_spec.rb

@@ -191,8 +191,8 @@ def test_user
       ssh_keys = [
         'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC/Ec2gummukPxlpPHZ7K96iBdG5n8v0PJEDvTVZRRFlS0QYa407gj9HuMrPjwEfVHqy+3KZmvKLWQBsSlf0Fn+eAPg' \
         'noqwVfZaJnfgkSxJiAzRraKQZX1m2wx2SVMfjw7/1j59zV60UhFiwEQ3Eqlg3xjQmjvrwDM+SoshrWB+TeqwO/K+QEP1ZbURYoCxc92GrLYWKixsAov/zr0loXqul9fy' \
-        'dZcWwJE3H/BWC7PTtn4jfjG9+9F+SZ0OMwQvSGKhVlj3GBDtaDBnsuoHGh/CA2W240nwpQysG2BJ5DWXu6vKbjNn6uV91wXeKDEDpuWqv5Vi2XAxGTWKc5lF0IJ5' \
-        ' nicolas@tchoum',
+        'dZcWwJE3H/BWC7PTtn4jfjG9+9F+SZ0OMwQvSGKhVlj3GBDtaDBnsuoHGh/CA2W240nwpQysG2BJ5DWXu6vKbjNn6uV91wXeKDEDpuWqv5Vi2XAxGTWKc5lF0IJ5 ' \
+        'nicolas@tchoum',
         'ssh-dss AAAAB3NzaC1kc3MAAACBAKscxrmjRgXtb0ZUaaBUteBtF2cI0vStnni9KVQd94L8qqxvKLbDl5JTKjUvG2s7rD4sVRzBoTkuDGb7OZLf56wJyF3k+k8uNRJz' \
         'vH/CZbkKM2hjuRVYVort1EwcH7JiEQr7bCLe7MRaltuo/M1vhapwy7fhKxAo9YoYVWiGoFTVAAAAFQDPywT8yFDahFvxtt/95Q9Emq8R7QAAAIBHYnvt3hT9NYy+nOuZ' \
         'G+cQTz0hnVzUIWuj0XF2iyx52s2eSmF0HxIsZ0D9g2A0L1Xr/vlkWBMq/zJZJgJw2Ifys8L47HzjhL8K0Skdm23Z6rQR9hlOEZ5Rcank98U6VRYPWpYk7OLdRDruwXb+' \