Don't rescue Exception (http://www.zenspider.com/Languages/Ruby/QuickRef.html#general-tips)

Author: root

Diff for: app/helpers/gitolite_hooks_helper.rb

@@ -23,7 +23,7 @@ def validate_encoded_time(clear_time, encoded_time, key)
           valid = true
         end
       end
-    rescue Exception => e
+    rescue => e
       logger.error { "Error in validate_encoded_time(): #{e.message}" }
     end
 

Diff for: lib/redmine_gitolite/admin.rb

@@ -141,7 +141,7 @@ def gitolite_admin_repo_push
     def get_lock_file
       begin
         lock_file ||= File.new(@lock_file_path, File::CREAT|File::RDONLY)
-      rescue Exception => e
+      rescue => e
         lock_file = nil
       end
 

Diff for: lib/redmine_gitolite/recycle.rb

@@ -123,7 +123,7 @@ def recover_repository_if_present?(repository)
       # Pull up any matching repositories. Sort them (beginning is representation of time)
       begin
         files = RedmineGitolite::GitHosting.execute_command(:shell_cmd, "find '#{@recycle_bin_dir}' -type d -regex '#{myregex}' -prune -print 2> /dev/null").chomp.split("\n").sort {|x, y| y <=> x }
-      rescue Exception => e
+      rescue RedmineGitolite::GitHosting::GitHostingException => e
         files = []
       end