Add tests for destroy method and actions with unsufficient permissions

Author: root

Diff for: spec/controllers/repository_mirrors_controller_spec.rb

@@ -113,17 +113,41 @@ def success_url
 
 
   describe "GET #edit" do
-    before do
-      request.session[:user_id] = @user.id
-      get :edit, :repository_id => @repository_git.id, :id => @mirror.id
+    context "with existing mirror" do
+      before do
+        request.session[:user_id] = @user.id
+        get :edit, :repository_id => @repository_git.id, :id => @mirror.id
+      end
+
+      it "assigns the requested mirror to @mirror" do
+        expect(assigns(:mirror)).to eq @mirror
+      end
+
+      it "renders the :edit template" do
+        expect(response).to render_template(:edit)
+      end
     end
 
-    it "assigns the requested mirror to @mirror" do
-      expect(assigns(:mirror)).to eq @mirror
+    context "with non-existing mirror" do
+      before do
+        request.session[:user_id] = @user.id
+        get :edit, :repository_id => @repository_git.id, :id => 100
+      end
+
+      it "renders 404" do
+        expect(response.status).to eq 404
+      end
     end
 
-    it "renders the :edit template" do
-      expect(response).to render_template(:edit)
+    context "with unsufficient permissions" do
+      before do
+        request.session[:user_id] = FactoryGirl.create(:user).id
+        get :edit, :repository_id => @repository_git.id, :id => @mirror.id
+      end
+
+      it "renders 403" do
+        expect(response.status).to eq 403
+      end
     end
   end
 
@@ -171,7 +195,7 @@ def success_url
 
       it "does not change @mirror's attributes" do
         @mirror.reload
-        expect(@mirror.url).to eq 'ssh://host.xz/path/to/repo.git'
+        expect(@mirror.url).to eq 'ssh://host.xz/path/to/repo1.git'
       end
 
       it "re-renders the :edit template" do
@@ -180,4 +204,21 @@ def success_url
     end
   end
 
+  describe 'DELETE destroy' do
+    before :each do
+      request.session[:user_id] = @user.id
+      @mirror = FactoryGirl.create(:repository_mirror, :repository_id => @repository_git.id)
+    end
+
+    it "deletes the mirror" do
+      expect{
+        delete :destroy, :repository_id => @repository_git.id, :id => @mirror.id, :format => 'js'
+      }.to change(RepositoryMirror, :count).by(-1)
+    end
+
+    it "redirects to repositories#edit" do
+      delete :destroy, :repository_id => @repository_git.id, :id => @mirror.id, :format => 'js'
+      expect(response.status).to eq 200
+    end
+  end
 end

Diff for: spec/controllers/repository_post_receive_urls_controller_spec.rb

@@ -69,17 +69,17 @@ def success_url
         expect{
           post :create, :repository_id => @repository_git.id,
                         :repository_post_receive_url => {
-                          :url => 'http://example.com',
-                          :push_mode => 0
+                          :url  => 'http://example.com',
+                          :mode => :github
                         }
         }.to change(RepositoryPostReceiveUrl, :count).by(1)
       end
 
       it "redirects to the repository page" do
         post :create, :repository_id => @repository_git.id,
                       :repository_post_receive_url => {
-                        :url => 'http://example2.com',
-                        :push_mode => 0
+                        :url  => 'http://example2.com',
+                        :mode => :github
                       }
         expect(response).to redirect_to(success_url)
       end
@@ -94,17 +94,17 @@ def success_url
         expect{
           post :create, :repository_id => @repository_git.id,
                         :repository_post_receive_url => {
-                          :url => 'example.com',
-                          :push_mode => 0
+                          :url  => 'example.com',
+                          :mode => :github
                         }
-        }.to_not change(RepositoryMirror, :count)
+        }.to_not change(RepositoryPostReceiveUrl, :count)
       end
 
       it "re-renders the :new template" do
         post :create, :repository_id => @repository_git.id,
                       :repository_post_receive_url => {
-                        :url => 'example.com',
-                        :push_mode => 0
+                        :url  => 'example.com',
+                        :mode => :github
                       }
         expect(response).to render_template(:new)
       end
@@ -113,17 +113,41 @@ def success_url
 
 
   describe "GET #edit" do
-    before do
-      request.session[:user_id] = @user.id
-      get :edit, :repository_id => @repository_git.id, :id => @post_receive_url.id
+    context "with existing post_receive_url" do
+      before do
+        request.session[:user_id] = @user.id
+        get :edit, :repository_id => @repository_git.id, :id => @post_receive_url.id
+      end
+
+      it "assigns the requested post_receive_url to @post_receive_url" do
+        expect(assigns(:post_receive_url)).to eq @post_receive_url
+      end
+
+      it "renders the :edit template" do
+        expect(response).to render_template(:edit)
+      end
     end
 
-    it "assigns the requested post_receive_url to @post_receive_url" do
-      expect(assigns(:post_receive_url)).to eq @post_receive_url
+    context "with non-existing post_receive_url" do
+      before do
+        request.session[:user_id] = @user.id
+        get :edit, :repository_id => @repository_git.id, :id => 100
+      end
+
+      it "renders 404" do
+        expect(response.status).to eq 404
+      end
     end
 
-    it "renders the :edit template" do
-      expect(response).to render_template(:edit)
+    context "with unsufficient permissions" do
+      before do
+        request.session[:user_id] = FactoryGirl.create(:user).id
+        get :edit, :repository_id => @repository_git.id, :id => @post_receive_url.id
+      end
+
+      it "renders 403" do
+        expect(response.status).to eq 403
+      end
     end
   end
 
@@ -171,7 +195,7 @@ def success_url
 
       it "does not change @post_receive_url's attributes" do
         @post_receive_url.reload
-        expect(@post_receive_url.url).to eq 'http://example.com/toto.php'
+        expect(@post_receive_url.url).to eq 'http://example.com/toto1.php'
       end
 
       it "re-renders the :edit template" do
@@ -180,4 +204,22 @@ def success_url
     end
   end
 
+
+  describe 'DELETE destroy' do
+    before :each do
+      request.session[:user_id] = @user.id
+      @post_receive_url = FactoryGirl.create(:repository_post_receive_url, :repository_id => @repository_git.id)
+    end
+
+    it "deletes the post_receive_url" do
+      expect{
+        delete :destroy, :repository_id => @repository_git.id, :id => @post_receive_url.id, :format => 'js'
+      }.to change(RepositoryPostReceiveUrl, :count).by(-1)
+    end
+
+    it "redirects to repositories#edit" do
+      delete :destroy, :repository_id => @repository_git.id, :id => @post_receive_url.id, :format => 'js'
+      expect(response.status).to eq 200
+    end
+  end
 end