Rework Gitolite hooks : add a small DSL to declare Gitolite hooks to install globally

Author: root

Diff for: app/use_cases/apply_settings.rb

@@ -33,7 +33,7 @@ def apply_settings
       check_repo_hierarchy
       check_gitolite_config
       check_gitolite_default_values
-      check_hook_install
+      check_hooks_install
       check_hook_config
       check_cache_config
 
@@ -94,14 +94,14 @@ def check_hook_config
          value_has_changed?(:gitolite_hooks_are_asynchronous)
 
         # Need to update our .gitconfig
-        RedmineGitHosting::HookManager.update_hook_params!
+        RedmineGitHosting::Config.update_hook_params!
       end
     end
 
 
-    def check_hook_install
+    def check_hooks_install
       ## Gitolite user has changed, check if this new one has our hooks!
-      RedmineGitHosting::HookManager.check_install! if value_has_changed?(:gitolite_user)
+      RedmineGitHosting::Config.check_hooks_install! if value_has_changed?(:gitolite_user)
     end
 
 

Diff for: app/views/settings/_gitolite_config_test.html.haml

@@ -24,11 +24,7 @@
     %td= l(:label_sudo_redmine_to_gitolite_user)
     %td= image_tag (RedmineGitHosting::Config.can_redmine_sudo_to_gitolite_user? ? 'true.png' : 'exclamation.png')
 
-  - gitolite_checks = RedmineGitHosting::HookManager.check_install!
-
-  %tr
-    %td= l(:label_gitolite_hook_dirs_installed)
-    %td= render_gitolite_params_status(gitolite_checks[:hook_dirs])
+  - gitolite_checks = RedmineGitHosting::Config.check_hooks_install!
 
   %tr
     %td= l(:label_gitolite_hooks_installed)