Skip to content

Commit d4938ff

Browse files
author
root
committed
Pass a hash of options to call_use_cases method
1 parent 0b94b34 commit d4938ff

5 files changed

+14
-20
lines changed

Diff for: app/controllers/redmine_git_hosting_controller.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,9 @@ def success_url
9595
end
9696

9797

98-
def call_use_case_and_redirect
98+
def call_use_case_and_redirect(opts = {})
9999
# Update Gitolite repository
100-
call_use_case
100+
call_use_case(opts)
101101
render_js_redirect
102102
end
103103

Diff for: app/controllers/repository_deployment_credentials_controller.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ def users_allowed_to_create_deployment_keys
112112
end
113113

114114

115-
def call_use_case
116-
options = { message: "Update deploy keys for repository : '#{@repository.gitolite_repository_name}'" }
115+
def call_use_case(opts = {})
116+
options = opts.merge({ message: "Update deploy keys for repository : '#{@repository.gitolite_repository_name}'" })
117117
GitoliteAccessor.update_repository(@repository, options)
118118
end
119119

Diff for: app/controllers/repository_git_config_keys_controller.rb

+6-12
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,17 @@ def create
3030
def update
3131
if @git_config_key.update_attributes(params[:repository_git_config_key])
3232
flash[:notice] = l(:notice_git_config_key_updated)
33-
call_use_case_and_redirect
33+
options = @git_config_key.key_has_changed? ? { delete_git_config_key: @git_config_key.old_key } : {}
34+
call_use_case_and_redirect(options)
3435
end
3536
end
3637

3738

3839
def destroy
3940
if @git_config_key.destroy
4041
flash[:notice] = l(:notice_git_config_key_deleted)
41-
call_use_case_and_redirect
42+
options = { delete_git_config_key: @git_config_key.key }
43+
call_use_case_and_redirect(options)
4244
end
4345
end
4446

@@ -58,16 +60,8 @@ def find_repository_git_config_key
5860
end
5961

6062

61-
def call_use_case
62-
case self.action_name
63-
when 'create'
64-
options = {}
65-
when 'update'
66-
options = @git_config_key.key_has_changed? ? { delete_git_config_key: @git_config_key.old_key } : {}
67-
when 'destroy'
68-
options = { delete_git_config_key: @git_config_key.key }
69-
end
70-
options = options.merge(message: "Rebuild Git config keys respository : '#{@repository.gitolite_repository_name}'")
63+
def call_use_case(opts = {})
64+
options = opts.merge(message: "Rebuild Git config keys respository : '#{@repository.gitolite_repository_name}'")
7165
GitoliteAccessor.update_repository(@repository, options)
7266
end
7367

Diff for: app/controllers/repository_git_notifications_controller.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ def set_current_tab
6060
end
6161

6262

63-
def call_use_case
64-
options = { message: "Rebuild mailing list for respository : '#{@repository.gitolite_repository_name}'" }
63+
def call_use_case(opts = {})
64+
options = opts.merge({ message: "Rebuild mailing list for respository : '#{@repository.gitolite_repository_name}'" })
6565
GitoliteAccessor.update_repository(@repository, options)
6666
end
6767

Diff for: app/controllers/repository_protected_branches_controller.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ def find_repository_protected_branch
7575
end
7676

7777

78-
def call_use_case
79-
options = { message: "Update branch permissions for repository : '#{@repository.gitolite_repository_name}'" }
78+
def call_use_case(opts = {})
79+
options = opts.merge({ message: "Update branch permissions for repository : '#{@repository.gitolite_repository_name}'" })
8080
GitoliteAccessor.update_repository(@repository, options)
8181
end
8282

0 commit comments

Comments
 (0)