Skip to content

Commit ce18c51

Browse files
author
ratty
committed
checking for duplicates is unneccesary when you're already hierarchica, or moving towards hierarchical
1 parent e5d9a68 commit ce18c51

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

app/forms/plugin_settings_validation/redmine_config.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ module RedmineConfig
4646
# Check duplication if we are switching from a mode to another
4747
#
4848
def check_for_duplicated_repo
49-
return if !Additionals.true?(current_setting(:hierarchical_organisation)) && Additionals.true?(hierarchical_organisation)
49+
return if Additionals.true?(hierarchical_organisation)
5050
return unless Repository::Xitolite.have_duplicated_identifier?
5151

5252
errors.add(:base, 'Detected non-unique repository identifiers. Cannot switch to flat mode')

0 commit comments

Comments
 (0)