Skip to content

Commit ca2c0c3

Browse files
author
root
committed
Fix namespace
1 parent 477dd09 commit ca2c0c3

File tree

4 files changed

+112
-109
lines changed

4 files changed

+112
-109
lines changed

Diff for: lib/redmine_git_hosting/config/gitolite_hooks.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def check_hooks_install!
6060

6161

6262
def update_hook_params!
63-
GlobalParams.new.installed?
63+
RedmineGitHosting::GitoliteParams::GlobalParams.new.installed?
6464
end
6565

6666
end
+17-16
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,29 @@
1-
module RedmineGitHosting::GitoliteParams
1+
module RedmineGitHosting
2+
module GitoliteParams
3+
module BaseParam
24

3-
module BaseParam
5+
private
46

5-
private
7+
def logger
8+
RedmineGitHosting.logger
9+
end
610

7-
def logger
8-
RedmineGitHosting.logger
9-
end
1011

12+
# Return a hash with global config parameters.
13+
def get_git_config_params(namespace)
14+
RedmineGitHosting::Commands.sudo_get_git_global_params(namespace)
15+
end
1116

12-
# Return a hash with global config parameters.
13-
def get_git_config_params(namespace)
14-
RedmineGitHosting::Commands.sudo_get_git_global_params(namespace)
15-
end
1617

18+
def set_git_config_param(namespace, key, value)
19+
RedmineGitHosting::Commands.sudo_set_git_global_param(namespace, key, value)
20+
end
1721

18-
def set_git_config_param(namespace, key, value)
19-
RedmineGitHosting::Commands.sudo_set_git_global_param(namespace, key, value)
20-
end
2122

23+
def unset_git_config_param(key)
24+
RedmineGitHosting::Commands.sudo_unset_git_global_param(key)
25+
end
2226

23-
def unset_git_config_param(key)
24-
RedmineGitHosting::Commands.sudo_unset_git_global_param(key)
2527
end
26-
2728
end
2829
end
+47-46
Original file line numberDiff line numberDiff line change
@@ -1,70 +1,71 @@
1-
module RedmineGitHosting::GitoliteParams
1+
module RedmineGitHosting
2+
module GitoliteParams
3+
class GlobalParams
24

3-
class GlobalParams
5+
include BaseParam
46

5-
include BaseParam
7+
attr_reader :gitolite_hooks_url
8+
attr_reader :debug_mode
9+
attr_reader :async_mode
610

7-
attr_reader :gitolite_hooks_url
8-
attr_reader :debug_mode
9-
attr_reader :async_mode
11+
attr_reader :namespace
12+
attr_reader :current_params
1013

11-
attr_reader :namespace
12-
attr_reader :current_params
1314

15+
def initialize
16+
# Params to set
17+
@gitolite_hooks_url = RedmineGitHosting::Config.gitolite_hooks_url
18+
@debug_mode = RedmineGitHosting::Config.gitolite_hooks_debug.to_s
19+
@async_mode = RedmineGitHosting::Config.gitolite_hooks_are_asynchronous.to_s
1420

15-
def initialize
16-
# Params to set
17-
@gitolite_hooks_url = RedmineGitHosting::Config.gitolite_hooks_url
18-
@debug_mode = RedmineGitHosting::Config.gitolite_hooks_debug.to_s
19-
@async_mode = RedmineGitHosting::Config.gitolite_hooks_are_asynchronous.to_s
21+
# Namespace where to set params
22+
@namespace = RedmineGitHosting::Config.gitolite_hooks_namespace
2023

21-
# Namespace where to set params
22-
@namespace = RedmineGitHosting::Config.gitolite_hooks_namespace
24+
# Get current params
25+
@current_params = get_git_config_params(@namespace)
2326

24-
# Get current params
25-
@current_params = get_git_config_params(@namespace)
26-
27-
# Build hash of installed params
28-
@installed = {}
29-
end
27+
# Build hash of installed params
28+
@installed = {}
29+
end
3030

3131

32-
def installed?
33-
gitolite_hooks_url_set?
34-
debug_mode_set?
35-
async_mode_set?
36-
@installed
37-
end
32+
def installed?
33+
gitolite_hooks_url_set?
34+
debug_mode_set?
35+
async_mode_set?
36+
@installed
37+
end
3838

3939

40-
private
40+
private
4141

4242

43-
def gitolite_hooks_url_set?
44-
if current_params['redmineurl'] != gitolite_hooks_url
45-
@installed['redmineurl'] = set_git_config_param(namespace, 'redmineurl', gitolite_hooks_url)
46-
else
47-
@installed['redmineurl'] = true
43+
def gitolite_hooks_url_set?
44+
if current_params['redmineurl'] != gitolite_hooks_url
45+
@installed['redmineurl'] = set_git_config_param(namespace, 'redmineurl', gitolite_hooks_url)
46+
else
47+
@installed['redmineurl'] = true
48+
end
4849
end
49-
end
5050

5151

52-
def debug_mode_set?
53-
if current_params['debugmode'] != debug_mode
54-
@installed['debugmode'] = set_git_config_param(namespace, 'debugmode', debug_mode)
55-
else
56-
@installed['debugmode'] = true
52+
def debug_mode_set?
53+
if current_params['debugmode'] != debug_mode
54+
@installed['debugmode'] = set_git_config_param(namespace, 'debugmode', debug_mode)
55+
else
56+
@installed['debugmode'] = true
57+
end
5758
end
58-
end
5959

6060

61-
def async_mode_set?
62-
if current_params['asyncmode'] != async_mode
63-
@installed['asyncmode'] = set_git_config_param(namespace, 'asyncmode', async_mode)
64-
else
65-
@installed['asyncmode'] = true
61+
def async_mode_set?
62+
if current_params['asyncmode'] != async_mode
63+
@installed['asyncmode'] = set_git_config_param(namespace, 'asyncmode', async_mode)
64+
else
65+
@installed['asyncmode'] = true
66+
end
6667
end
67-
end
6868

69+
end
6970
end
7071
end
+47-46
Original file line numberDiff line numberDiff line change
@@ -1,69 +1,70 @@
1-
module RedmineGitHosting::GitoliteParams
1+
module RedmineGitHosting
2+
module GitoliteParams
3+
class MailerParams
24

3-
class MailerParams
5+
include BaseParam
46

5-
include BaseParam
7+
attr_reader :namespace
8+
attr_reader :current_params
9+
attr_reader :current_mailer_params
610

7-
attr_reader :namespace
8-
attr_reader :current_params
9-
attr_reader :current_mailer_params
1011

12+
def initialize
13+
## Namespace where to set params
14+
@namespace = 'multimailhook'
1115

12-
def initialize
13-
## Namespace where to set params
14-
@namespace = 'multimailhook'
16+
## Get current params
17+
@current_params = get_git_config_params(@namespace)
18+
@current_mailer_params = get_mailer_params
1519

16-
## Get current params
17-
@current_params = get_git_config_params(@namespace)
18-
@current_mailer_params = get_mailer_params
19-
20-
# Build hash of installed params
21-
@installed = {}
22-
end
20+
# Build hash of installed params
21+
@installed = {}
22+
end
2323

2424

25-
def installed?
26-
mailer_params.each do |param|
27-
if current_params[param] != current_mailer_params[param]
28-
@installed[param] = set_git_config_param(namespace, param, current_mailer_params[param])
29-
else
30-
@installed[param] = true
25+
def installed?
26+
mailer_params.each do |param|
27+
if current_params[param] != current_mailer_params[param]
28+
@installed[param] = set_git_config_param(namespace, param, current_mailer_params[param])
29+
else
30+
@installed[param] = true
31+
end
3132
end
33+
@installed
3234
end
33-
@installed
34-
end
3535

3636

37-
private
37+
private
3838

3939

40-
def mailer_params
41-
%w(mailer environment smtpauth smtpserver smtpport smtpuser smtppass)
42-
end
40+
def mailer_params
41+
%w(mailer environment smtpauth smtpserver smtpport smtpuser smtppass)
42+
end
4343

4444

45-
def get_mailer_params
46-
params = {}
47-
params['environment'] = 'gitolite'
48-
params['mailer'] = mailer
49-
params['smtpauth'] = smtpauth_enabled?.to_s
50-
params['smtpserver'] = ActionMailer::Base.smtp_settings[:address].to_s
51-
params['smtpport'] = ActionMailer::Base.smtp_settings[:port].to_s
52-
params['smtpuser'] = ActionMailer::Base.smtp_settings[:user_name] || ''
53-
params['smtppass'] = ActionMailer::Base.smtp_settings[:password] || ''
54-
params
55-
end
45+
def get_mailer_params
46+
params = {}
47+
params['environment'] = 'gitolite'
48+
params['mailer'] = mailer
49+
params['smtpauth'] = smtpauth_enabled?.to_s
50+
params['smtpserver'] = ActionMailer::Base.smtp_settings[:address].to_s
51+
params['smtpport'] = ActionMailer::Base.smtp_settings[:port].to_s
52+
params['smtpuser'] = ActionMailer::Base.smtp_settings[:user_name] || ''
53+
params['smtppass'] = ActionMailer::Base.smtp_settings[:password] || ''
54+
params
55+
end
5656

5757

58-
def mailer
59-
ActionMailer::Base.delivery_method == :smtp ? 'smtp' : 'sendmail'
60-
end
58+
def mailer
59+
ActionMailer::Base.delivery_method == :smtp ? 'smtp' : 'sendmail'
60+
end
6161

6262

63-
def smtpauth_enabled?
64-
auth = ActionMailer::Base.smtp_settings[:authentication]
65-
auth != nil && auth != '' && auth != :none
66-
end
63+
def smtpauth_enabled?
64+
auth = ActionMailer::Base.smtp_settings[:authentication]
65+
auth != nil && auth != '' && auth != :none
66+
end
6767

68+
end
6869
end
6970
end

0 commit comments

Comments
 (0)