Add redmine_plugin_kit and switch used Additionals methods to it

Author: alexandermeindl

Diff for: Gemfile

@@ -6,6 +6,8 @@ gem 'gitolite-rugged', git: 'https://github.com/jbox-web/gitolite-rugged.git', t
 # Ruby/Rack Git Smart-HTTP Server Handler
 gem 'gitlab-grack', '~> 2.0.0', git: 'https://github.com/jbox-web/grack.git', require: 'grack', branch: 'fix_gemfile'
 
+gem 'redmine_plugin_kit'
+
 # Memcached client for GitCache
 gem 'dalli'
 

Diff for: app/forms/plugin_settings_validation/redmine_config.rb

@@ -21,14 +21,14 @@ module RedmineConfig
       # hierarchical_organisation and unique_repo_identifier are now combined
       #
       before_validation do
-        self.unique_repo_identifier = if Additionals.true? hierarchical_organisation
+        self.unique_repo_identifier = if RedminePluginKit.true? hierarchical_organisation
                                         'false'
                                       else
                                         'true'
                                       end
 
         ## If we don't auto-create repository, we cannot create README file
-        self.init_repositories_on_create = 'false' unless Additionals.true? all_projects_use_git
+        self.init_repositories_on_create = 'false' unless RedminePluginKit.true? all_projects_use_git
       end
 
       validates :redmine_has_rw_access_on_all_repos, presence: true, inclusion: { in: RedmineGitHosting::Validators::BOOLEAN_FIELDS }
@@ -48,7 +48,7 @@ module RedmineConfig
     # Check duplication if we are switching from a mode to another
     #
     def check_for_duplicated_repo
-      return if Additionals.true? hierarchical_organisation
+      return if RedminePluginKit.true? hierarchical_organisation
       return unless Repository::Xitolite.have_duplicated_identifier?
 
       errors.add :base, 'Detected non-unique repository identifiers. Cannot switch to flat mode'

Diff for: app/models/repository/xitolite.rb

@@ -66,8 +66,8 @@ def mirror_push(url, branch, args = [])
   private
 
   def valid_repository_options
-    return unless Additionals.true? create_readme
-    return unless Additionals.true? enable_git_annex
+    return if RedminePluginKit.false? create_readme
+    return if RedminePluginKit.false? enable_git_annex
 
     errors.add :base, :invalid_options
   end

Diff for: app/presenters/repository_presenter.rb

@@ -58,7 +58,7 @@ def render_clipboard_button
   end
 
   def committer_label(value)
-    Additionals.true?(value[:committer]) ? l(:label_read_write_permission) : l(:label_read_only_permission)
+    RedminePluginKit.true?(value[:committer]) ? l(:label_read_write_permission) : l(:label_read_only_permission)
   end
 
   def element_name

Diff for: app/use_cases/settings/apply.rb

@@ -148,7 +148,7 @@ def do_delete_trash_repo
     end
 
     def do_add_redmine_rw_access
-      if Additionals.true? current_setting(:redmine_has_rw_access_on_all_repos)
+      if RedminePluginKit.true? current_setting(:redmine_has_rw_access_on_all_repos)
         gitolite_accessor.enable_rw_access
       else
         gitolite_accessor.disable_rw_access

Diff for: app/views/settings/_redmine_git_hosting.html.slim

@@ -5,14 +5,16 @@
 span
   = l :label_need_help
   ' :
-  = link_to l(:label_redmine_git_hosting_wiki), RedmineGitHosting::Config::GITHUB_WIKI, class: 'external'
+  = link_to_external l(:label_redmine_git_hosting_wiki),
+                     RedmineGitHosting::Config::GITHUB_WIKI
 
 br
 
 span
   = l :label_open_issue
   ' :
-  = link_to l(:label_redmine_git_hosting_issue), RedmineGitHosting::Config::GITHUB_ISSUE, class: 'external'
+  = link_to_external l(:label_redmine_git_hosting_issue),
+                     RedmineGitHosting::Config::GITHUB_ISSUE
 
 br
 br

Diff for: assets/stylesheets/.stylelintignore

@@ -137,7 +137,7 @@ def up
       when 'deleteGitRepositories'
         new_setting[:delete_git_repositories] = value
       when 'gitRepositoryHierarchy'
-        if Additionals.true? value
+        if RedminePluginKit.true? value
           new_setting[:hierarchical_organisation] = 'true'
           new_setting[:unique_repo_identifier] = 'false'
         else

Diff for: db/migrate/20130807223227_migrate_parameters.rb

@@ -9,6 +9,8 @@
 module RedmineGitHosting
   extend self
 
+  VERSION = '5.0.1-master'
+
   # Load RedminePluginLoader
   require 'redmine_git_hosting/redmine_plugin_loader'
   extend RedminePluginLoader

Diff for: lib/redmine_git_hosting.rb

@@ -13,7 +13,7 @@ module Base
 
       def get_setting(setting, bool = false)
         if bool
-          Additionals.true? do_get_setting(setting)
+          RedminePluginKit.true? do_get_setting(setting)
         else
           do_get_setting setting
         end

Diff for: lib/redmine_git_hosting/config/base.rb

@@ -83,11 +83,11 @@ def creation_options
       end
 
       def create_readme_file?
-        Additionals.true? @repository.create_readme
+        RedminePluginKit.true? @repository.create_readme
       end
 
       def enable_git_annex?
-        Additionals.true? @repository.enable_git_annex
+        RedminePluginKit.true? @repository.enable_git_annex
       end
 
       REV_PARAM_RE = /\A[a-f0-9]*\Z/i

Diff for: lib/redmine_git_hosting/patches/repositories_controller_patch.rb

@@ -17,7 +17,7 @@ def post_update
     private
 
     def update_default_branch?
-      Additionals.true? update_default_branch
+      RedminePluginKit.true? update_default_branch
     end
 
     def do_update_default_branch

Diff for: lib/redmine_git_hosting/plugins/extenders/branch_updater.rb

@@ -26,7 +26,7 @@ def installable?
     end
 
     def enable_git_annex?
-      Additionals.true? enable_git_annex
+      RedminePluginKit.true? enable_git_annex
     end
 
     def git_annex_installed?

Diff for: lib/redmine_git_hosting/plugins/extenders/git_annex_creator.rb

@@ -28,7 +28,7 @@ def installable?
     end
 
     def create_readme_file?
-      Additionals.true? create_readme_file
+      RedminePluginKit.true? create_readme_file
     end
 
     def do_create_readme_file

Diff for: lib/redmine_git_hosting/plugins/extenders/readme_creator.rb

@@ -15,7 +15,7 @@ def initialize(repository_data, _options = {})
     private
 
     def delete_repository?
-      Additionals.true? delete_repository
+      RedminePluginKit.true? delete_repository
     end
   end
 end