Fix #358

Author: root

Diff for: app/helpers/gitolite_plugin_settings_helper.rb

@@ -20,7 +20,7 @@ def image_for_param(bool)
 
 
   def render_gitolite_version(version)
-    if version <= 0
+    if version.nil?
       css_class = 'label label-important'
       label = l(:label_unknown_gitolite_version)
     else

Diff for: lib/redmine_git_hosting/commands/gitolite.rb

@@ -23,6 +23,10 @@ def gitolite_infos
 
 
       def sudo_update_gitolite!
+        if gitolite_command.nil?
+          logger.error("gitolite_command is nil, can't update Gitolite !")
+          return
+        end
         logger.info("Running '#{gitolite_command.join(' ')}' on the Gitolite install ...")
         begin
           sudo_shell(*gitolite_command)

Diff for: lib/redmine_git_hosting/config/gitolite_infos.rb

@@ -21,7 +21,7 @@ def gitolite_infos
         begin
           RedmineGitHosting::Commands.gitolite_infos
         rescue RedmineGitHosting::Error::GitoliteCommandException => e
-          logger.error('Error while getting Gitolite infos')
+          logger.error('Error while getting Gitolite infos, check your SSH keys path or your Git user.')
           nil
         end
       end
@@ -40,14 +40,14 @@ def gitolite_banner
 
 
       def find_version(output)
-        return 0 if output.blank?
+        return nil if output.blank?
         line = output.split("\n")[0]
         if line =~ /gitolite[ -]v?2./
           2
         elsif line.include?('running gitolite3')
           3
         else
-          0
+          nil
         end
       end