Fix repository settings form template to work with redmine 4.x

Patch from comments in issue #742
(#742 (comment))

Author: mathprod

Diff for: Gemfile

@@ -42,7 +42,7 @@ group :development, :test do
   gem 'database_cleaner'
   gem 'factory_bot_rails', '< 5.0'
 
-  gem 'rubocop', require: false
+  gem 'rubocop', '~> 0.76.0', require: false
   gem 'rubocop-rspec'
 
   # Publish to CodeClimate

Diff for: app/controllers/redmine_git_hosting_controller.rb

@@ -54,6 +54,9 @@ def render_with_api
   def render_js_redirect
     respond_to do |format|
       format.js { render js: "window.location = #{success_url.to_json};" }
+      format.html do
+        redirect_to success_url
+      end
     end
   end
 

Diff for: app/views/repository_deployment_credentials/edit.html.slim

@@ -1,5 +1,5 @@
 = labelled_form_for :repository_deployment_credential, @credential,
-                    url: repository_deployment_credential_path(@repository, @credential),
+                    url: repository_deployment_credential_path(@repository, @credential), authenticity_token: form_authenticity_token,
                     html: { method: :put, class: 'tabular', remote: true } do |f|
 
   .flash-messages = error_messages_for 'credential'

Diff for: app/views/repository_deployment_credentials/new.html.slim

@@ -1,5 +1,5 @@
 = labelled_form_for :repository_deployment_credential, @credential,
-                    url: repository_deployment_credentials_path(@repository),
+                    url: repository_deployment_credentials_path(@repository), authenticity_token: form_authenticity_token,
                     html: { method: :post, class: 'tabular', remote: true } do |f|
 
   .flash-messages= error_messages_for 'credential'

Diff for: app/views/repository_git_config_keys/edit.html.slim

@@ -1,5 +1,5 @@
 = labelled_form_for :repository_git_config_key, @git_config_key,
-                    url: repository_git_config_key_path(@repository, @git_config_key),
+                    url: repository_git_config_key_path(@repository, @git_config_key), authenticity_token: form_authenticity_token,
                     html: { method: :put, class: 'tabular', remote: true } do |f|
 
   = render partial: 'form', locals: { f: f }

Diff for: app/views/repository_git_config_keys/new.html.slim

@@ -1,5 +1,5 @@
 = labelled_form_for :repository_git_config_key, @git_config_key,
-                    url: repository_git_config_keys_path(@repository),
+                    url: repository_git_config_keys_path(@repository), authenticity_token: form_authenticity_token,
                     html: { method: :post, class: 'tabular', remote: true } do |f|
 
   = render partial: 'form', locals: { f: f }

Diff for: app/views/repository_git_extras/move.html.slim

@@ -2,7 +2,7 @@ h2 = l(:label_move_repository, repo_name: @repository.gitolite_repository_name)
 
 .box
   = labelled_form_for :repository_mover, @move_repository_form,
-                      url: move_repository_git_extras_path(@repository),
+                      url: move_repository_git_extras_path(@repository), authenticity_token: form_authenticity_token,
                       html: { method: :post, class: 'tabular', data: { confirm: l(:text_are_you_sure) } } do |f|
 
     .flash-messages = error_messages_for 'move_repository_form'

Diff for: app/views/repository_mirrors/edit.html.slim

@@ -1,5 +1,5 @@
 = labelled_form_for :repository_mirror, @mirror,
-                    url: repository_mirror_path(@repository, @mirror),
+                    url: repository_mirror_path(@repository, @mirror), authenticity_token: form_authenticity_token,
                     html: { method: :put, class: 'tabular', remote: true } do |f|
 
   = render partial: 'form', locals: { f: f }

Diff for: app/views/repository_mirrors/new.html.slim

@@ -1,5 +1,5 @@
 = labelled_form_for :repository_mirror, @mirror,
-                    url: repository_mirrors_path(@repository),
+                    url: repository_mirrors_path(@repository), authenticity_token: form_authenticity_token,
                     html: { method: :post, class: 'tabular', remote: true } do |f|
 
   = render partial: 'form', locals: { f: f }

Diff for: app/views/repository_post_receive_urls/edit.html.slim

@@ -1,5 +1,5 @@
 = labelled_form_for :repository_post_receive_url, @post_receive_url,
-                    url: repository_post_receive_url_path(@repository, @post_receive_url),
+                    url: repository_post_receive_url_path(@repository, @post_receive_url), authenticity_token: form_authenticity_token,
                     html: { method: :put, class: 'tabular', remote: true } do |f|
 
   = render partial: 'form', locals: { f: f }

Diff for: app/views/repository_post_receive_urls/new.html.slim

@@ -1,5 +1,5 @@
 = labelled_form_for :repository_post_receive_url, @post_receive_url,
-                    url: repository_post_receive_urls_path(@repository),
+                    url: repository_post_receive_urls_path(@repository), authenticity_token: form_authenticity_token,
                     html: { method: :post, class: 'tabular', remote: true } do |f|
 
   = render partial: 'form', locals: { f: f }

Diff for: app/views/repository_protected_branches/edit.html.slim

@@ -1,5 +1,5 @@
 = labelled_form_for :repository_protected_branche, @protected_branch,
-                    url: repository_protected_branch_path(@repository, @protected_branch),
+                    url: repository_protected_branch_path(@repository, @protected_branch), authenticity_token: form_authenticity_token,
                     html: { method: :put, class: 'tabular', remote: true } do |f|
 
   = render partial: 'form', locals: { f: f }

Diff for: app/views/repository_protected_branches/new.html.slim

@@ -1,5 +1,5 @@
 = labelled_form_for :repository_protected_branche, @protected_branch,
-                    url: repository_protected_branches_path(@repository),
+                    url: repository_protected_branches_path(@repository), authenticity_token: form_authenticity_token,
                     html: { method: :post, class: 'tabular', remote: true } do |f|
 
   = render partial: 'form', locals: { f: f }