Fix potential bugs when moving repositories

Author: Nicolas Rodriguez

Diff for: lib/redmine_git_hosting/gitolite_handlers/repository_mover.rb

@@ -17,7 +17,7 @@ def initialize(repository, gitolite_config, action)
       def call
         if !repo_conf
           logger.error("#{action} : repository '#{old_repo_name}' does not exist in Gitolite, exit !")
-          return
+          nil
         else
           perform_repository_move
         end
@@ -41,6 +41,8 @@ def perform_repository_move
 
             # Return old path to delete it
             old_relative_parent_path
+          else
+            nil
           end
         end
 

Diff for: lib/redmine_git_hosting/gitolite_wrapper/projects.rb

@@ -81,7 +81,7 @@ def handle_repositories_move(git_projects)
           delete_parent_path = []
           git_projects.reverse.each do |project|
             project.gitolite_repos.reverse.each do |repository|
-              repo_list.push << repository.gitolite_repository_name
+              repo_list << repository.gitolite_repository_name
               delete_parent_path << RedmineGitHosting::GitoliteHandlers::RepositoryMover.new(repository, gitolite_config, action).call
             end
             gitolite_admin_repo_commit("#{action} : #{project.identifier} | #{repo_list}")