Fix #413

Author: root

Diff for: app/views/common/_git_urls.html.haml

@@ -19,4 +19,4 @@
   #git_url_box= l(:label_repository_access_not_configured)
 
 :javascript
-  $(document).ready(function() { setFirstGitUrl('.git_url_list'); bindGitUrls('.git_url'); });
+  $(document).ready(function() { setGitUrls('.git_url'); });

Diff for: app/views/repositories/git_instructions.html.haml

@@ -55,22 +55,4 @@
       = render 'common/git_urls', repository: @repository
 
 :javascript
-  $(document).ready(function() {
-    var key = $('.git_url_list li').first().attr('id');
-    var access = access_list[key];
-
-    $('.git_url_access').html(access.url);
-
-    $('.git_url_list li').on('click', function(){
-      var key  = $(this).attr('id');
-      var access = access_list[key];
-
-      $('.git_url_access').html(access.url);
-
-      if (access.committer == true) {
-        $('#repository_setup').show();
-      } else {
-        $('#repository_setup').hide();
-      }
-    });
-  });
+  $(document).ready(function() { setGitUrlsInstructions('.git_url'); });

Diff for: assets/javascripts/application.js

@@ -37,6 +37,7 @@ function trigger_mode_change(element) {
   }
 }
 
+// GIT URLS
 function updateUrl(element) {
   var url = $(element).data('url');
   var target = $(element).data('target');
@@ -47,21 +48,41 @@ function updateUrl(element) {
   $(element).addClass('selected');
 }
 
-function setFirstGitUrl(elements) {
+function setGitUrls(elements) {
   $(elements).each(function(index, element){
-    var first_url = $(element).children().first();
-    updateUrl(first_url);
+    if (index == 0){
+      updateUrl(element);
+    };
+    $(element).on('click', function(){
+      updateUrl($(this));
+    });
   });
 }
 
-function bindGitUrls(elements) {
+// GIT INSTRUCTIONS
+function updateInstructionUrl(element) {
+  var url = $(element).data('url');
+  var committer = $(element).data('committer');
+  $('.git_url_access').html(url);
+  if (committer == 'RW') {
+    $('#repository_setup').show();
+  } else {
+    $('#repository_setup').hide();
+  }
+}
+
+function setGitUrlsInstructions(elements) {
   $(elements).each(function(index, element){
+    if (index == 0){
+      updateInstructionUrl(element);
+    };
     $(element).on('click', function(){
-      updateUrl($(this));
+      updateInstructionUrl($(this));
     });
   });
 }
 
+// REPOSITORY EDIT
 function setRepositoryActiveTab(current_tab) {
   var all_tabs = $("#repository-tabs li");
   var active_tab = '';