Skip to content

Commit 705297c

Browse files
author
root
committed
Be sure to use non interactive sudo (The -n option prevents sudo from prompting the user for a password)
1 parent 753b70b commit 705297c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Diff for: lib/redmine_gitolite/config.rb

+4-4
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ def self.can_gitolite_sudo_to_redmine_user?
260260
end
261261

262262
begin
263-
test = RedmineGitolite::GitHosting.execute_command(:shell_cmd, "sudo -inu #{redmine_user} whoami")
263+
test = RedmineGitolite::GitHosting.execute_command(:shell_cmd, "sudo -n -u #{redmine_user} -i whoami")
264264
if test.match(/#{redmine_user}/)
265265
logger.info { "OK!" }
266266
@@sudo_gitolite_to_redmine_user_cached = true
@@ -531,10 +531,10 @@ def self.git_cmd_script_is_installed?
531531
f.puts "else"
532532
if sudo_version < SUDO_VERSION_SWITCH
533533
f.puts ' cmd=$(printf "\\\\\\"%s\\\\\\" " "$@")'
534-
f.puts " sudo -u #{gitolite_user} -i eval \"git $cmd\""
534+
f.puts " sudo -n -u #{gitolite_user} -i eval \"git $cmd\""
535535
else
536536
f.puts ' cmd=$(printf "\\"%s\\" " "$@")'
537-
f.puts " sudo -u #{gitolite_user} -i eval \"git $cmd\""
537+
f.puts " sudo -n -u #{gitolite_user} -i eval \"git $cmd\""
538538
end
539539
f.puts 'fi'
540540
end
@@ -593,7 +593,7 @@ def self.shell_cmd_script_is_installed?
593593
f.puts " $command =~ s/'/\\\\\\\\'/g;"
594594
end
595595
f.puts ' $command =~ s/"/\\\\"/g;'
596-
f.puts ' exec("sudo -u ' + gitolite_user + ' -i eval \"$command\"");'
596+
f.puts ' exec("sudo -n -u ' + gitolite_user + ' -i eval \"$command\"");'
597597
f.puts '}'
598598
end
599599

0 commit comments

Comments
 (0)