Add tests for Project, fix #230

Author: root

Diff for: config/locales/active_record/en.yml

@@ -4,10 +4,20 @@ en:
 
   activerecord:
     errors:
+
+      models:
+
+        repository:
+          attributes:
+            identifier:
+              ident_cannot_equal_project: ": cannot match identifier of existing project"
+
+        project:
+          attributes:
+            identifier:
+              ident_invalid: ": invalid identifier"
+              ident_not_unique: ": matches existing repository identifier"
+
       messages:
-        'may not be changed': 'may not be changed'
         cannot_change: "cannot be changed"
-        ident_not_unique: "matches existing repository identifier"
-        ident_cannot_equal_project: "cannot match identifier of existing project"
         blank_default_exists: "Cannot make repository the default because current default has blank identifier."
-        error_wrong_config_key_format: "Wrong key format (must contain at least one '.')."

Diff for: config/locales/active_record/fr.yml

@@ -4,10 +4,20 @@ fr:
 
   activerecord:
     errors:
+
+      models:
+
+        repository:
+          attributes:
+            identifier:
+              ident_cannot_equal_project: ": ne peut pas correspondre à l'identifiant d'un projet existant"
+
+        project:
+          attributes:
+            identifier:
+              ident_invalid: ": identifiant invalide"
+              ident_not_unique: ": correspond à un identifiant de dépôt existant"
+
       messages:
-        'may not be changed': 'ne peut pas être changé'
         cannot_change: "ne peut pas changer"
-        ident_not_unique: "correspond à un identifiant de dépôt existant"
-        ident_cannot_equal_project: "ne peut pas correspondre à l'identifiant d'un projet existant"
         blank_default_exists: "Ne peut pas mettre le dépôt par défaut, car le dépôt par défaut courant a un identifiant vide."
-        error_wrong_config_key_format: "Mauvais format de clé (doit contenir au moin un '.')"

Diff for: lib/redmine_git_hosting/patches/project_patch.rb

@@ -37,6 +37,10 @@ def additional_ident_constraints
           if new_record? && !identifier.blank? && Repository.find_by_identifier_and_type(identifier, "Repository::Git")
             errors.add(:identifier, :ident_not_unique)
           end
+
+          if new_record? && !identifier.blank? && identifier == 'gitolite-admin'
+            errors.add(:identifier, :ident_invalid)
+          end
         end
 
       end

Diff for: spec/models/project_spec.rb

@@ -0,0 +1,36 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe Project do
+
+  before(:all) do
+    @project    = FactoryGirl.create(:project)
+
+    @git_repo_1 = FactoryGirl.create(:repository_git, :project_id => @project.id, :is_default => true)
+    @git_repo_2 = FactoryGirl.create(:repository_git, :project_id => @project.id, :identifier => 'git-repo-test')
+
+    @svn_repo_1 = FactoryGirl.create(:repository_svn, :project_id => @project.id, :identifier => 'svn-repo-test', :url => 'http://svn-repo-test')
+  end
+
+  subject { @project }
+
+  ## Test relations
+  it { should respond_to(:gitolite_repos) }
+  it { should respond_to(:repo_blank_ident) }
+
+  it "should have 1 repository with blank ident" do
+    expect(@project.repo_blank_ident).to eq @git_repo_1
+  end
+
+  it "should have 2 Git repositories" do
+    expect(@project.gitolite_repos).to eq [@git_repo_1, @git_repo_2 ]
+  end
+
+  it "should not match existing repository identifier" do
+    expect(FactoryGirl.build(:project, :identifier => 'git-repo-test')).to be_invalid
+  end
+
+  it "should not match Gitolite Admin repository identifier" do
+    expect(FactoryGirl.build(:project, :identifier => 'gitolite-admin')).to be_invalid
+  end
+
+end