Skip to content

Commit 54ff944

Browse files
committed
Fixed other cases that looked at repo identifiers in single-repo mode
1 parent 36f6047 commit 54ff944

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

Diff for: lib/git_adapter_hooks.rb

+4-2
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ def self.setup_hooks_for_repository(repo,value_hash=nil)
202202
# if no value_hash given, go fetch
203203
value_hash = get_local_config_params(repo) if value_hash.nil?
204204
hook_key = repo.extra.key
205-
if value_hash["hooks.redmine_gitolite.key"] != hook_key || value_hash["hooks.redmine_gitolite.projectid"] != repo.project.identifier || value_hash["hooks.redmine_gitolite.repositoryid"] != (repo.identifier || "")
205+
if value_hash["hooks.redmine_gitolite.key"] != hook_key || value_hash["hooks.redmine_gitolite.projectid"] != repo.project.identifier || GitHosting.multi_repos? && (value_hash["hooks.redmine_gitolite.repositoryid"] != (repo.identifier || ""))
206206
if value_hash["hooks.redmine_gitolite.key"]
207207
logger.info "Repairing hooks for repository '#{GitHosting.repository_name(repo)}' (in gitolite repository at '#{GitHosting.repository_path(repo)}')"
208208
else
@@ -213,7 +213,9 @@ def self.setup_hooks_for_repository(repo,value_hash=nil)
213213
repo_path = GitHosting.repository_path(repo)
214214
GitHosting.shell %[#{GitHosting.git_exec} --git-dir='#{repo_path}' config hooks.redmine_gitolite.key "#{hook_key}"]
215215
GitHosting.shell %[#{GitHosting.git_exec} --git-dir='#{repo_path}' config hooks.redmine_gitolite.projectid "#{repo.project.identifier}"]
216-
GitHosting.shell %[#{GitHosting.git_exec} --git-dir='#{repo_path}' config hooks.redmine_gitolite.repositoryid "#{repo.identifier||''}"]
216+
if GitHosting.multi_repos?
217+
GitHosting.shell %[#{GitHosting.git_exec} --git-dir='#{repo_path}' config hooks.redmine_gitolite.repositoryid "#{repo.identifier||''}"]
218+
end
217219
rescue
218220
logger.error "setup_hooks_for_repository(#{repo.git_label}) failed!"
219221
end

Diff for: lib/git_hosting.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -1102,7 +1102,7 @@ def self.closest_path(path_list,repo_name,repo)
11021102
#
11031103
# Make sure that there isn't another repo who owns this path (only possible if we have non-unique
11041104
# repository identifiers--verify case #3, i.e. that we are not about to create non-unique identifier)
1105-
if repo.identifier.blank? || Repository.repo_ident_unique? || path_list.first && (path_list.first.match(/^(.*\/)?#{repo.git_label}$/))
1105+
if !GitHosting.multi_repos? || repo.identifier.blank? || Repository.repo_ident_unique? || path_list.first && (path_list.first.match(/^(.*\/)?#{repo.git_label}$/))
11061106
return path_list.first
11071107
else
11081108
return nil
@@ -1132,7 +1132,7 @@ def self.closest_path(path_list,repo_name,repo)
11321132
path_list.each {|test_path| return test_path if test_path==repo_name}
11331133

11341134
# Special handling if repository name could change with Repository.repo_ident_unique?
1135-
if !repo.identifier.blank? && GitHosting.multi_repos?
1135+
if GitHosting.multi_repos? && !repo.identifier.blank?
11361136
# See if we find match by merely changing value of Repository.repo_ident_unique?
11371137
repo_name_alt = repository_name(repo,:assume_unique => !Repository.repo_ident_unique?)
11381138
path_list.each {|test_path| return test_path if test_path==repo_name_alt}

0 commit comments

Comments
 (0)