An async socket now closes the write stream (synchronously) when it is deleted.

A StreamWriter does not reliably close its socket when it is collected.

Author: kristjanvalur

redis/asyncio/connection.py

@@ -207,6 +207,9 @@ def __repr__(self):
         repr_args = ",".join((f"{k}={v}" for k, v in self.repr_pieces()))
         return f"{self.__class__.__name__}<{repr_args}>"
 
+    def __del__(self):
+        self._close_socket()
+
     @abstractmethod
     def repr_pieces(self):
         pass
@@ -377,6 +380,15 @@ async def disconnect(self, nowait: bool = False) -> None:
                 f"Timed out closing connection after {self.socket_connect_timeout}"
             ) from None
 
+    def _close_socket(self):
+        """Close the socket directly.  Used during garbage collection to
+        make sure the underlying socket is released.  This does not happen
+        reliably when the stream is garbage collected.
+        """
+        if self._writer:
+            if os.getpid() == self.pid:
+                self._writer.close()
+
     async def _send_ping(self):
         """Send PING, expect PONG in return"""
         await self.send_command("PING", check_health=False)