Skip to content

Commit ea00678

Browse files
author
Ben Buckman
committed
undo initial RedisShardingClient. more advanced but still incomplete version is on the sharding-client branch. explanation in readme.
1 parent 169566a commit ea00678

File tree

3 files changed

+4
-29
lines changed

3 files changed

+4
-29
lines changed

README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,4 +71,7 @@ Now use `sentinelClient` as a regular client: `set`, `get`, `hmset`, etc.
7171

7272
# `RedisShardingClient`
7373

74-
To be continued...
74+
**We decided to abandon this after starting to build it.** The concept was another abstraction layer that behaved transparently like a `RedisClient`, but handled sharding (on key) in the background between a ring of multiple clients.
75+
For our particular application (or any particular application), however, the complexity such an abstraction layer involves is not worth the trouble, and a much simpler application-specific abstraction makes a lot more sense.
76+
77+
If anyone is interested in continuing this line of development, see the [sharding-client](https://github.com/DocuSignDev/node_redis/tree/sharding-client) branch.

index.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1113,12 +1113,6 @@ var Sentinel = require('./lib/sentinel');
11131113
exports.RedisSentinelClient = Sentinel.RedisSentinelClient;
11141114

11151115

1116-
// sharding client. instantiate separately.
1117-
var Sharding = require('./lib/sharding');
1118-
exports.RedisShardingClient = Sharding.RedisShardingClient;
1119-
1120-
1121-
11221116
exports.createClient = function (port_arg, host_arg, options) {
11231117
var redis_client;
11241118
var net_client;

lib/sharding.js

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)