fix(TransformationType): move TransformationType to separate file, remove duplicate definition and use strings for the enum type. Fixes typestack#147 See also: angular/angular-cli#7613 (comment)

Author: realmar

src/ClassTransformer.ts

@@ -1,5 +1,6 @@
 import {ClassTransformOptions} from "./ClassTransformOptions";
-import {TransformOperationExecutor, TransformationType} from "./TransformOperationExecutor";
+import {TransformOperationExecutor} from "./TransformOperationExecutor";
+import {TransformationType} from "./TransformationType";
 
 export type ClassType<T> = {
     new (...args: any[]): T;

src/TransformOperationExecutor.ts

@@ -1,12 +1,7 @@
 import {ClassTransformOptions} from "./ClassTransformOptions";
 import {defaultMetadataStorage} from "./storage";
 import {TypeOptions} from "./metadata/ExposeExcludeOptions";
-
-export enum TransformationType {
-    PLAIN_TO_CLASS,
-    CLASS_TO_PLAIN,
-    CLASS_TO_CLASS
-}
+import {TransformationType} from "./TransformationType";
 
 export class TransformOperationExecutor {
 

src/TransformationType.ts

@@ -0,0 +1,8 @@
+/**
+ * Enum representing the different transformation types.
+ */
+export enum TransformationType {
+    PLAIN_TO_CLASS = "0",
+    CLASS_TO_PLAIN = "1",
+    CLASS_TO_CLASS = "2"
+}

src/decorators.ts

@@ -6,7 +6,7 @@ import {ExposeOptions, ExcludeOptions, TypeOptions, TransformOptions} from "./me
 import {ExcludeMetadata} from "./metadata/ExcludeMetadata";
 import {TransformMetadata} from "./metadata/TransformMetadata";
 import {ClassTransformOptions} from "./ClassTransformOptions";
-import {TransformationType} from "./TransformOperationExecutor";
+import {TransformationType} from "./TransformationType";
 
 /**
  * Defines a custom logic for value transformation.

src/index.ts

@@ -3,6 +3,8 @@ import {ClassTransformOptions} from "./ClassTransformOptions";
 
 export {ClassTransformer} from "./ClassTransformer";
 export {ClassTransformOptions} from "./ClassTransformOptions";
+import {TransformationType} from "./TransformationType";
+
 export * from "./metadata/ExposeExcludeOptions";
 export * from "./decorators";
 
@@ -90,13 +92,3 @@ export function deserialize<T>(cls: ClassType<T>, json: string, options?: ClassT
 export function deserializeArray<T>(cls: ClassType<T>, json: string, options?: ClassTransformOptions): T[] {
     return classTransformer.deserializeArray(cls, json, options);
 }
-
-/**
- * Enum representing the different transformation types.
- */
-
-export enum TransformationType {
-    PLAIN_TO_CLASS,
-    CLASS_TO_PLAIN,
-    CLASS_TO_CLASS
-}

src/metadata/MetadataStorage.ts

@@ -1,7 +1,7 @@
 import {TypeMetadata} from "./TypeMetadata";
 import {ExposeMetadata} from "./ExposeMetadata";
 import {ExcludeMetadata} from "./ExcludeMetadata";
-import {TransformationType} from "../TransformOperationExecutor";
+import {TransformationType} from "../TransformationType";
 import {TransformMetadata} from "./TransformMetadata";
 
 /**

src/metadata/TransformMetadata.ts

@@ -1,5 +1,5 @@
 import {TransformOptions} from "./ExposeExcludeOptions";
-import {TransformationType} from "../TransformOperationExecutor";
+import {TransformationType} from "../TransformationType";
 
 export class TransformMetadata {
 

test/functional/custom-transform.spec.ts

@@ -3,8 +3,8 @@ import {expect} from "chai";
 import {classToPlain, plainToClass} from "../../src/index";
 import {defaultMetadataStorage} from "../../src/storage";
 import {Expose, Transform, Type} from "../../src/decorators";
+import {TransformationType} from "../../src/TransformationType";
 import * as moment from "moment";
-import {TransformationType} from "../../src/TransformOperationExecutor";
 
 describe("custom transformation decorator", () => {
 
@@ -158,7 +158,7 @@ describe("custom transformation decorator", () => {
         objArg.should.be.equal(user);
         typeArg.should.be.equal(TransformationType.CLASS_TO_PLAIN);
     });
-    
+
     let model: any;
     it ("should serialize json into model instance of class Person", () => {
         expect(() => {
@@ -184,24 +184,24 @@ describe("custom transformation decorator", () => {
             }
             class Address {
                 public street: string;
-                
-                @Expose({ name: "tel" }) 
+
+                @Expose({ name: "tel" })
                 public telephone: string;
-                
+
                 public zip: number;
-                
+
                 public country: string;
             }
             class Person {
                 public name: string;
-                
+
                 @Type(() => Address)
                 public address: Address;
-                
+
                 @Type(() => Hobby)
                 @Transform(value => value.filter((hobby: any) => hobby.type === "sport"), { toClassOnly: true })
                 public hobbies: Hobby[];
-                
+
                 public age: number;
             }
             model = plainToClass(Person, json);
@@ -210,7 +210,7 @@ describe("custom transformation decorator", () => {
             model.hobbies.forEach((hobby: Hobby) => expect(hobby instanceof Hobby && hobby.type === "sport"));
         }).to.not.throw();
     });
-    
+
     it ("should serialize a model into json", () => {
         expect(() => {
             classToPlain(model);