readyset-sql: Update expression conversion with MySQL CAST support

See relevant sqlparser [PR].

[PR]: apache/datafusion-sqlparser-rs#1739

Change-Id: I11a01b48f1649c6530cdbe7bd23c158e9fe4f888

Author: mvzink

readyset-sql/src/ast/expression.rs

@@ -443,9 +443,25 @@ impl From<sqlparser::ast::BinaryOperator> for BinaryOperator {
             BinOp::Question => todo!(),
             BinOp::QuestionAnd => Self::QuestionMarkAnd,
             BinOp::QuestionPipe => Self::QuestionMarkPipe,
-            BinOp::Spaceship => unimplemented!("<=> {value:?}"),
+            BinOp::Spaceship => todo!(),
             BinOp::StringConcat => todo!(),
             BinOp::Xor => todo!(),
+            BinOp::DoubleHash => todo!(),
+            BinOp::LtDashGt => todo!(),
+            BinOp::AndLt => todo!(),
+            BinOp::AndGt => todo!(),
+            BinOp::LtLtPipe => todo!(),
+            BinOp::PipeGtGt => todo!(),
+            BinOp::AndLtPipe => todo!(),
+            BinOp::PipeAndGt => todo!(),
+            BinOp::LtCaret => todo!(),
+            BinOp::GtCaret => todo!(),
+            BinOp::QuestionHash => todo!(),
+            BinOp::QuestionDash => todo!(),
+            BinOp::QuestionDashPipe => todo!(),
+            BinOp::QuestionDoublePipe => todo!(),
+            BinOp::At => todo!(),
+            BinOp::TildeEq => todo!(),
         }
     }
 }
@@ -496,20 +512,27 @@ pub enum UnaryOperator {
     Not,
 }
 
-impl From<sqlparser::ast::UnaryOperator> for UnaryOperator {
-    fn from(value: sqlparser::ast::UnaryOperator) -> Self {
+impl TryFrom<sqlparser::ast::UnaryOperator> for UnaryOperator {
+    type Error = AstConversionError;
+
+    fn try_from(value: sqlparser::ast::UnaryOperator) -> Result<Self, Self::Error> {
         use sqlparser::ast::UnaryOperator as UnOp;
         match value {
-            UnOp::Plus => todo!(),
-            UnOp::Minus => Self::Neg,
-            UnOp::Not => Self::Not,
+            UnOp::Plus => not_yet_implemented!("Unary + operator"),
+            UnOp::Minus => Ok(Self::Neg),
+            UnOp::Not => Ok(Self::Not),
             UnOp::PGBitwiseNot
             | UnOp::PGSquareRoot
             | UnOp::PGCubeRoot
             | UnOp::PGPostfixFactorial
             | UnOp::PGPrefixFactorial
-            | UnOp::PGAbs => unimplemented!("unsupported postgres unary operator"),
-            UnOp::BangNot => unimplemented!("unsupported bang not (!)"),
+            | UnOp::PGAbs => unsupported!("unsupported postgres unary operator"),
+            UnOp::BangNot
+            | UnOp::Hash
+            | UnOp::AtDashAt
+            | UnOp::DoubleAt
+            | UnOp::QuestionDash
+            | UnOp::QuestionPipe => unsupported!("unsupported unary operator {value}"),
         }
     }
 }
@@ -796,6 +819,7 @@ impl TryFromDialect<sqlparser::ast::Expr> for Expr {
                 expr,
                 data_type,
                 format: _, // TODO: I think this is where we would support `AT TIMEZONE` syntax
+                mysql_style_int: _, // TODO: We render this incorrectly
             } => Ok(Self::Cast {
                 expr: expr.try_into_dialect(dialect)?,
                 ty: data_type.try_into_dialect(dialect)?,
@@ -1002,7 +1026,7 @@ impl TryFromDialect<sqlparser::ast::Expr> for Expr {
                 }),
             },
             UnaryOp { op, expr } => Ok(Self::UnaryOp {
-                op: op.into(),
+                op: op.try_into()?,
                 rhs: expr.try_into_dialect(dialect)?,
             }),
             Value(value) => Ok(Self::Literal(value.try_into()?)),

readyset-sql/src/ast/sql_type.rs

@@ -262,6 +262,9 @@ impl TryFromDialect<sqlparser::ast::DataType> for crate::ast::SqlType {
             Trigger => skipped!("TRIGGER"),
             AnyType => unsupported!("ANY TYPE"),
             Table(_column_definition_list) => unsupported!("TABLE type"),
+            GeometricType(geometric_type_kind) => {
+                unsupported!("geometric type {geometric_type_kind}")
+            }
         }
     }
 }